Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal CMake version #338

Closed
nim65s opened this issue Feb 28, 2020 · 4 comments
Closed

Minimal CMake version #338

nim65s opened this issue Feb 28, 2020 · 4 comments

Comments

@nim65s
Copy link
Collaborator

nim65s commented Feb 28, 2020

Hi,

Configuring hpp-fcl on Debian 8 (oldoldstable) with CMake 3.0.2 raises the following error:

CMake Error at cmake/GNUInstallDirs.cmake:128 (cmake_policy):
Policy "CMP0054" is not known to this version of CMake.
Call Stack (most recent call first):
cmake/post-project.cmake:7 (INCLUDE)
CMakeLists.txt:70 (PROJECT)

So I think we can either:

  1. Decide that we require CMake >= 3.1
  2. Fix this

As this has been here for some time and nobody complained yet, I'm in favor of the first solution :)
nim65s added a commit to nim65s/robotpkg that referenced this issue Feb 28, 2020
@nim65s
[devel/jrl-cmakemodules] require CMake >= 3.1
8487a00 
ref jrl-umi3218/jrl-cmakemodules#338

Affected packages:
- math/pinocchio
- math/py-pinocchio
nim65s added a commit to nim65s/robotpkg-wip that referenced this issue Feb 28, 2020
@nim65s
[devel/jrl-cmakemodules] require CMake >= 3.1
22e1279 
ref jrl-umi3218/jrl-cmakemodules#338

Affected WIP packages:
- wip/eiquadprog
- wip/example-robot-data
- wip/py-example-robot-data
nim65s added a commit to nim65s/robotpkg that referenced this issue Feb 28, 2020
@nim65s
[devel/jrl-cmakemodules] require CMake >= 3.1
b67be2e 
ref jrl-umi3218/jrl-cmakemodules#338

Affected packages:
- math/pinocchio
- math/py-pinocchio
@jcarpent
Copy link
Contributor

Big step forwards if we decide to only support cmake >= 3.1. How it will behave on robotpkg? Which distributions are now outdated?

@nim65s
Copy link
Collaborator Author

nim65s commented Feb 28, 2020

Actually, I found this error message in the only distribution failing on hpp-fcl on robotpkg, and that's Debian 8: http://robotpkg.openrobots.org/rbulk/robotpkg/path/hpp-fcl/index.html#hpp-fcl-1.3.0.

CentOS 7 is also outdated, but this was already filtered out because this is not even 3.0

nim65s added a commit to nim65s/robotpkg-wip that referenced this issue Feb 28, 2020
@nim65s
[devel/jrl-cmakemodules] require CMake >= 3.1
120f7b4 
ref jrl-umi3218/jrl-cmakemodules#338

Affected WIP packages:
- wip/eiquadprog
- wip/example-robot-data
- wip/py-example-robot-data
nim65s added a commit to nim65s/robotpkg-wip that referenced this issue Mar 1, 2020
@nim65s
[devel/jrl-cmakemodules] require CMake >= 3.1
728ae13 
ref jrl-umi3218/jrl-cmakemodules#338

Affected WIP packages:
- wip/eiquadprog
- wip/example-robot-data
- wip/py-example-robot-data
nim65s added a commit to nim65s/robotpkg that referenced this issue Mar 9, 2020
@nim65s
[devel/jrl-cmakemodules] require CMake >= 3.1
0f23535 
ref jrl-umi3218/jrl-cmakemodules#338

Affected packages:
- math/pinocchio
- math/py-pinocchio
nim65s added a commit to nim65s/robotpkg-wip that referenced this issue Mar 11, 2020
@nim65s
[devel/jrl-cmakemodules] require CMake >= 3.1
ca787e4 
ref jrl-umi3218/jrl-cmakemodules#338

Affected WIP packages:
- wip/eiquadprog
- wip/example-robot-data
- wip/py-example-robot-data
nim65s added a commit to nim65s/robotpkg-wip that referenced this issue Mar 13, 2020
@nim65s
[devel/jrl-cmakemodules] require CMake >= 3.1
82cb4ea 
ref jrl-umi3218/jrl-cmakemodules#338

Affected WIP packages:
- wip/eiquadprog
- wip/example-robot-data
- wip/py-example-robot-data
@gergondet
Copy link
Member

I came across this today which might be helpful to determine the lowest cmake version required on your projects: https://github.com/nlohmann/cmake_min_version

nim65s added a commit to humanoid-path-planner/hpp-fcl that referenced this issue Apr 2, 2020
@nim65s
[CMake] require 3.1
d3837ad 
ref. jrl-umi3218/jrl-cmakemodules#338
@nim65s nim65s mentioned this issue May 26, 2020
Closed
@nim65s nim65s mentioned this issue Oct 13, 2020
Merged
nim65s added a commit to nim65s/eigenpy that referenced this issue Dec 14, 2020
@nim65s
[CMake] update minimum version
f73c516 
fix for:
CMake Deprecation Warning at CMakeLists.txt:6 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

ref jrl-umi3218/jrl-cmakemodules#338
nim65s added a commit to nim65s/eigenpy that referenced this issue Dec 14, 2020
@nim65s
[CMake] update minimum version
efc3922 
Recent CMake versions added this warning:
CMake Deprecation Warning at CMakeLists.txt:6 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

And we are not compatible with CMake < 3.1:
ref jrl-umi3218/jrl-cmakemodules#338
@nim65s nim65s mentioned this issue Dec 14, 2020
Merged
@nim65s nim65s mentioned this issue Aug 16, 2021
Merged
nim65s added a commit to nim65s/jrl-cmakemodules that referenced this issue Aug 16, 2021
@nim65s
update minimum required to 3.1
96f7352 
fix warnings like:

> CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
>   Compatibility with CMake < 2.8.12 will be removed from a future version of
>   CMake.

also ref. jrl-umi3218#338
stevenjj pushed a commit to stevenjj/hpp-fcl that referenced this issue Oct 26, 2021
@nim65s
[CMake] require 3.1
d0af743 
ref. jrl-umi3218/jrl-cmakemodules#338


Former-commit-id: d3837ad
@olivier-stasse
Copy link
Member

olivier-stasse commented Jun 23, 2023 •
edited
Loading

Dear all,
On Focal/18.04 the cmake release version is 3.10 and its EOL is 2023. Thus I propose that it becomes the minimal version for cmake below which we do not support jrl-cmakemodules.
https://launchpad.net/ubuntu/bionic/+source/cmake

nim65s added a commit to nim65s/eigenpy that referenced this issue Sep 16, 2023
@nim65s
CMake: require >= 3.10
7bcacfa 
ref. jrl-umi3218/jrl-cmakemodules#338
and fix deprecation warning about CMake 3.5 from CMake 3.27
nim65s added a commit to nim65s/hpp-fcl that referenced this issue Sep 16, 2023
@nim65s
CMake: require >= 3.10
f0dc277 
ref. jrl-umi3218/jrl-cmakemodules#338
and fix deprecation warning about CMake 3.5 from CMake 3.27
This was referenced Sep 16, 2023
Merged
Merged
nim65s added a commit to nim65s/pinocchio that referenced this issue Sep 16, 2023
@nim65s
CMake: require >= 3.10
66a2354 
ref. jrl-umi3218/jrl-cmakemodules#338
and fix deprecation warning about CMake 3.5 from CMake 3.27
@nim65s nim65s mentioned this issue Sep 16, 2023
Merged
nim65s added a commit to nim65s/example-robot-data that referenced this issue Sep 16, 2023
@nim65s
CMake: require >= 3.10
effa412 
ref. jrl-umi3218/jrl-cmakemodules#338
and fix deprecation warning about CMake 3.5 from CMake 3.27
@nim65s nim65s mentioned this issue Sep 16, 2023
Merged
nim65s added a commit to nim65s/tsid that referenced this issue Sep 16, 2023
@nim65s
CMake: require >= 3.10
77f15d6 
ref. jrl-umi3218/jrl-cmakemodules#338
and fix deprecation warning about CMake 3.5 from CMake 3.27
@nim65s nim65s mentioned this issue Sep 16, 2023
Merged
nim65s added a commit to nim65s/ndcurves that referenced this issue Sep 16, 2023
@nim65s
CMake: require >= 3.10
066e815 
ref. jrl-umi3218/jrl-cmakemodules#338
and fix deprecation warning about CMake 3.5 from CMake 3.27
This was referenced Sep 16, 2023
Closed
Merged
@nim65s nim65s closed this as completed in dc7efae Sep 19, 2023
nim65s added a commit that referenced this issue Sep 19, 2023
@nim65s
Merge pull request #620 from jrl-umi3218/cmake-3.10
9924c7e 
require CMake >= 3.10, fix #338
jcarpent pushed a commit to nim65s/hpp-fcl that referenced this issue Sep 25, 2023
@nim65s @jcarpent
CMake: require >= 3.10
5869a50 
ref. jrl-umi3218/jrl-cmakemodules#338
and fix deprecation warning about CMake 3.5 from CMake 3.27
nim65s added a commit to MaximilienNaveau/multicontact-api that referenced this issue Oct 10, 2023
@nim65s
CMake: require >= 3.10
1e3d7a2 
ref. jrl-umi3218/jrl-cmakemodules#338
and fix deprecation warning about CMake 3.5 from CMake 3.27
olivier-stasse pushed a commit to stack-of-tasks/tsid that referenced this issue Oct 22, 2023
@nim65s @olivier-stasse
CMake: require >= 3.10
d29223a 
ref. jrl-umi3218/jrl-cmakemodules#338
and fix deprecation warning about CMake 3.5 from CMake 3.27
nim65s added a commit to loco-3d/ndcurves that referenced this issue Nov 29, 2023
@nim65s
CMake: require >= 3.10
1a91766 
ref. jrl-umi3218/jrl-cmakemodules#338
and fix deprecation warning about CMake 3.5 from CMake 3.27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nim65s @olivier-stasse @gergondet @jcarpent