Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Edit feature plugin documentation #1265

Closed

Conversation

micahellison
Copy link
Member

@micahellison micahellison commented Jun 19, 2021

This builds on the namespace-based export plugins #1006. I want to do what I can to make sure that this documentation is relatively easy and approachable for new plugin developers.

Done so far:

  • use same style as the rest of the documentation (informal "you", jrnl instead of jrnl, minimize passive voice)
  • remove justification for change, since this is a how-to guide
  • add reference to Python namespace package docs
  • use tip/warning tooltip styles
  • order documentation in order from general to specific

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

@micahellison micahellison added the documentation Improvements or additions to documentation label Jun 19, 2021
@micahellison
Copy link
Member Author

When I started working on this, I thought it would be a good sub-section of the new Contributing section in #1180 but after actually seeing it, I realized it makes a lot more sense to keep it separate. Writing your own plugin is a lot different than contributing directly to the jrnl project, and a lot of the contributing documentation isn't even related to coding.

In the long run, I think we'll want an additional user doc on installing plugins, so we end up with two main plugin docs. I made issue #1267 for that.

@wren wren force-pushed the feature-plugins branch 2 times, most recently from 29235a9 to 79c3740 Compare July 17, 2021 21:58
@MinchinWeb
Copy link
Contributor

Hey @micahellison ! Further to f228149, I really think we should keep the sample plugins as part of the displayed documentation.

  1. Keeping them in means that the (generated) documentation is self-contained, which means you can turn it in to a PDF and read it offline.
  2. Keeping the plugin inline reduces context changes. My hope is that the plugin documentation is expansive and comprehensive enough that you could write your plugins based on the documentation alone, without having to context-swtich to find something elsewhere on the internet.

I specifically wrote as simple a complete plugin as I could with an eye of putting these in the documentation, and they come in at 40 and 50 lines. If these are two long, maybe we should put some work on slimming them down.

Hope my couple thoughts helps.

@micahellison
Copy link
Member Author

HI @MinchinWeb, funnily enough, I removed the included code because I found the context change of a page full of code really jarring. It might be appropriate for a tutorial, but I don't believe it's appropriate for a reference, except as an addendum rather than than something that interrupts the flow of an article. Splitting up the docs could help with this.

Also, I am still not feeling great about the example code. I understand your motivation for wanting to have a short-as-possible example of a plugin, but I'm far more concerned that providing an incomplete example as the bedrock for a whole plugin ecosystem may end up causing lots of difficulty for both us and the users. That's why I filed #1268, with the hopes that creating a sample plugin repo with some testing infrastructure would lead to well-tested plugins.

- use same style as the rest of the documentation (informal "you", `jrnl` instead of *jrnl*, minimize passive voice)
- remove justification for change - this is a how-to guide rather than a change management doc
- add namespace package reference
- use tip/warning tooltip styles
- order documentation in order from general to specific rather than specific to general
@micahellison
Copy link
Member Author

Fixed some merge issues but tests are failing now -- looks like it's due to linting issues on the feature-plugins branch.

@stale
Copy link

stale bot commented Nov 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Inactive issue: will be closed soon if no activity label Nov 16, 2021
@micahellison
Copy link
Member Author

Closing due to staleness. I'll get back to this if/when the feature-plugin branch stabilizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation stale Inactive issue: will be closed soon if no activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants