-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Edit feature plugin documentation #1265
[WIP] Edit feature plugin documentation #1265
Conversation
When I started working on this, I thought it would be a good sub-section of the new Contributing section in #1180 but after actually seeing it, I realized it makes a lot more sense to keep it separate. Writing your own plugin is a lot different than contributing directly to the jrnl project, and a lot of the contributing documentation isn't even related to coding. In the long run, I think we'll want an additional user doc on installing plugins, so we end up with two main plugin docs. I made issue #1267 for that. |
29235a9
to
79c3740
Compare
Hey @micahellison ! Further to f228149, I really think we should keep the sample plugins as part of the displayed documentation.
I specifically wrote as simple a complete plugin as I could with an eye of putting these in the documentation, and they come in at 40 and 50 lines. If these are two long, maybe we should put some work on slimming them down. Hope my couple thoughts helps. |
HI @MinchinWeb, funnily enough, I removed the included code because I found the context change of a page full of code really jarring. It might be appropriate for a tutorial, but I don't believe it's appropriate for a reference, except as an addendum rather than than something that interrupts the flow of an article. Splitting up the docs could help with this. Also, I am still not feeling great about the example code. I understand your motivation for wanting to have a short-as-possible example of a plugin, but I'm far more concerned that providing an incomplete example as the bedrock for a whole plugin ecosystem may end up causing lots of difficulty for both us and the users. That's why I filed #1268, with the hopes that creating a sample plugin repo with some testing infrastructure would lead to well-tested plugins. |
- use same style as the rest of the documentation (informal "you", `jrnl` instead of *jrnl*, minimize passive voice) - remove justification for change - this is a how-to guide rather than a change management doc - add namespace package reference - use tip/warning tooltip styles - order documentation in order from general to specific rather than specific to general
…n markdown line length
ec263f8
to
dc30527
Compare
Fixed some merge issues but tests are failing now -- looks like it's due to linting issues on the feature-plugins branch. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closing due to staleness. I'll get back to this if/when the feature-plugin branch stabilizes. |
This builds on the namespace-based export plugins #1006. I want to do what I can to make sure that this documentation is relatively easy and approachable for new plugin developers.
Done so far:
jrnl
instead of jrnl, minimize passive voice)Checklist
for the same issue.