Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin list on Diagnostic #1282

Merged
merged 7 commits into from
Oct 16, 2021
Merged

Conversation

MinchinWeb
Copy link
Contributor

Further to #1006, displays active plugins on --diagnostic rather than --version

@wren
Copy link
Member

wren commented Jul 13, 2021

I forgot to comment on this after our conversation in #1006, sorry!

This PR is dependent on what we decide to do with versions numbers for internal plugins, so I don't think we should merge this yet. I'm going to mark it as a draft for now until that conversation is finished.

@wren wren marked this pull request as draft July 13, 2021 19:49
@wren wren force-pushed the feature-plugins branch 2 times, most recently from 29235a9 to 79c3740 Compare July 17, 2021 21:58
@stale
Copy link

stale bot commented Sep 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Inactive issue: will be closed soon if no activity label Sep 21, 2021
@MinchinWeb
Copy link
Contributor Author

Not stale.

Suggested format (from here):

Formats:
    Import:
        jrnl    : jrnl (internal)
    Export:
        boxed   : fancy (internal)
        default : custom-default v1.1.0 from foo.bar.somewhere_else
        foo     : bar v1.3
  1. "Formats", "Import, and "Export in the titles so it's more consistent with the docs
  2. Include the name of the plugin even if it's internal
  3. Only include the from foo.bar.whatever if the plugin is not at the default location (so there's less noise for the defaults)
  4. Line up the colons so it's more consistent with other general output

@stale stale bot removed the stale Inactive issue: will be closed soon if no activity label Sep 22, 2021
@MinchinWeb
Copy link
Contributor Author

Output looks like:

λ jrnl --diagnostic
jrnl: v2.8.1
Python: 3.9.7 (tags/v3.9.7:1016ef3, Aug 30 2021, 20:19:38) [MSC v.1929 64 bit (AMD64)]
OS: Windows 10

Active Plugins:
    Importers:
        jrnl     : jrnl (internal)
        json     : simple_json v1.0.0
    Exporters:
        boxed    : fancy (internal)
        dates    : dates (internal)
        default  : pretty (internal)
        fancy    : fancy (internal)
        json     : custom_json v1.0.0
        markdown : markdown (internal)
        md       : markdown (internal)
        pretty   : pretty (internal)
        rot13    : rot13 v1.0.0
        short    : short (internal)
        tags     : tag (internal)
        test     : flag v0.0.1
        testing  : flag v0.0.1
        text     : text (internal)
        txt      : rot13 v1.0.0
        xml      : xml (internal)
        yaml     : yaml (internal)

Tests appear to be failing because the skip tags aren't working, but that is beyond the scope of this PR (adjusting plugin info display). Also, Windows tests don't appear to run at all.


I think it's ready to merge.

@MinchinWeb MinchinWeb marked this pull request as ready for review October 11, 2021 20:56
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for making the updates!

@wren wren merged commit 80a1eef into jrnl-org:feature-plugins Oct 16, 2021
MinchinWeb added a commit to MinchinWeb/minchin.jrnl that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants