Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where changelog is always slightly out of date on release tags #1631

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

wren
Copy link
Member

@wren wren commented Oct 30, 2022

As the title says, there's currently a bug in our release process where the release is tagged and published, and then the changelog is updated afterward. You can actually see it if you go through the tags in our repo and click on the changelog file for each one.

This PR makes it a part of the changelog step in CI to update the tag to the proper commit after the changelog is generated (the changelog generator itself requires a tag to work, which is why the tag has to be moved afterward instead of beforehand).

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

.github/workflows/changelog.yaml Outdated Show resolved Hide resolved
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏷

@micahellison micahellison added the build Issues related to the build pipeline label Nov 1, 2022
@micahellison micahellison merged commit 8ad9e2b into jrnl-org:develop Nov 1, 2022
@micahellison micahellison deleted the fix-tagging-release branch November 1, 2022 23:50
@micahellison micahellison linked an issue Nov 19, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants