Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag to XML file when edited DayOne entry and is searchable afterward #1648

Merged
merged 8 commits into from
Jan 7, 2023

Conversation

jonakeys
Copy link
Contributor

@jonakeys jonakeys commented Dec 2, 2022

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

Fixes #1049
When DayOne entry is edited and a tag is added, jrnl now adds this tags correctly to the XML file.
Also included a BDD test for DayOne and different configs.

@jonakeys
Copy link
Contributor Author

jonakeys commented Dec 3, 2022

Problem during regression tests..

@jonakeys
Copy link
Contributor Author

jonakeys commented Dec 4, 2022

Now working with all tests. Had to fix the random order in which tags are saved to prevent seeing it as modified while the items stayed the same.

@micahellison micahellison added the bug Something isn't working label Jan 7, 2023
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@wren wren merged commit 907566b into jrnl-org:develop Jan 7, 2023
@jonakeys jonakeys deleted the issue1049 branch January 8, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags aren't saved in XML when editing DayOne entries, and can't be searched for afterward
3 participants