Git #44 : Correcting an issue raised in 2.1 where PluggableRenderContext… #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dominic Jones seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account (for further information, click here). |
dominic-jones
force-pushed
the
render-context-override
branch
from
41bd9c8
to
85f3101
Compare
|
@dominic-jones Thanks! Please sign the Contributor License Agreement and I'll be happy to merge your changes in. |
…rContext is created multiple times during the initialisation of BasicVisualizationServer, resulting in renderContext fields to be discarded. Since all constructors defer to a primary constructor, the other two initialisations of renderContext have been removed.
dominic-jones
force-pushed
the
render-context-override
branch
from
85f3101
to
fd834f4
Compare
|
I've tried signing this, several times. Seems that somehow my commit had a different author/committer on closer inspection. CLA plugin seemed a bit fussy, is all. All lined up now. |
|
Yeah, I've had that problem with signing as well; sorry you ran into it. Thanks! |
This was referenced Sep 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… is created multiple times during the initialisation of BasicVisualizationServer, resulting in renderContext fields to be discarded. Since all constructors defer to a primary constructor, the other two initialisations of renderContext have been removed.