WIP create executable jar using jruby-main artifact #38

mkristian · 2015-04-18T18:22:16Z

pack all jar-dependencies into root of the jar using a maven repository layout
use either main which runs completely from the jar or an extracting main which
first extracts the jar into a temporary directory
shades both jruby-complete and jruby-mains into the executable jar using
gradle zipTree, i.e. all shadowJar is gone
remove compat version and let jruby-mains pick .jrubyrc from the jar-file
which can set the compat version when needed
init script support is broken

Sponsored by Lookout Inc.

mkristian · 2015-04-18T18:23:05Z

depends on jruby-gradle/jruby-gradle-plugin#110

still work to be done

mkristian · 2015-04-20T02:49:15Z

needs: jruby/jruby-mains#1

mkristian · 2015-04-20T12:53:17Z

some remarks:

the defaultMain will not work
- with older jruby-versions - jruby-1.7.19+ work with running directly from the jar
- when the code tries to relaunch "ruby" like the rspec task for rake does then you need to use the extractingMain. the extractingMain is slower on startup since it first needs unpack the jar
gem dependencies with or without jar-dependencies work
adding "extra" jar artifacts along with the gems does only work if the application does Jars.require_jars_lock! (part of jar-dependencies) at some point.
there a two more issues open with jruby-mains:
- have special properties to control hard-exit jruby/jruby-mains#3 - currently the jar has a System.exit at the end
- look for .jrubyrc at archive root and use it jruby/jruby-mains#2 - especially meant for setting the compat.version of JRuby also looking at jruby-9k which has no compat version anymore

ysb33r · 2015-04-20T20:28:53Z

src/main/groovy/com/github/jrubygradle/jar/JRubyJarConfigurator.groovy

@@ -24,15 +24,6 @@ class JRubyJarConfigurator {
        configure()
    }

-    @PackageScope


I'm not sure whether I am happy with dropping shadowJar support completely. What I do think is to definitely remove it from a fixed dependency in build.gradle. It might still be worthwhile for someone who want to use that instead to go that way bu explicitly including it in their buildscript and applying the plugin.

OK, sounds fair to treat jar and shadowJar alike. will put it back.

on second thought: I moved back the shadowJar option for jruby-gradle-jar-plugin BUT things will not really work when you use it since all those embedded jars are gone and jruby-main will look for them and not find them.

ysb33r · 2015-04-20T20:58:11Z

with older jruby-versions - jruby-1.7.19+ work with running directly from the jar

We can just force this to say that as from v0.1.4, jruby 1.7.19 is a requirement. We could print a warning at least in the code.

when the code tries to relaunch "ruby" like the rspec task for rake does then you need to use the extractingMain. the extractingMain is slower on startup since it first needs unpack the jar

Will extractingMain clean up the temporary files afterwards?

mkristian · 2015-04-21T05:58:57Z

@ysb33r
https://github.com/mkristian/jruby-mains/blob/master/src/main/java/de/saumya/mojo/mains/ExtractedZip.java#L54

this works more or less. if you have more or better ideas please speak up - especially on windows things are bit stricter.

rtyler · 2015-04-29T00:47:01Z

Now that I've created the 0.1.16 base plugin, should this be updated?

mkristian · 2015-05-01T21:01:15Z

src/main/groovy/com/github/jrubygradle/jar/JRubyJarPlugin.groovy

+            }
+            project.tasks.withType(Jar) { task ->
+                if (task.name == 'jar') {
+                    finalizedBy( 'jrubyJar' )


this finalizeBy is a hack - any suggestions on how to do it better are welcome.

but the idea is 'jar' tasks collects all resources and on the fly gnerates those .jrubydir files for this resourecs

after this 'jrubyJar' takes the first jar and all jrubyJars and packs the fat-jar

rtyler · 2015-05-01T21:51:15Z

At first blush this looks ifne to me, I'll wait for @ysb33r to take a peek before I merge it.

ysb33r · 2015-05-05T22:25:10Z

build.gradle

+    testRepo ('org.jruby:jruby-complete:1.7.19') {
+        transitive = false
+    }
+    testRepo ('de.saumya.mojo:jruby-mains:0.1.0') {


Needs to be 0.2.0

ysb33r · 2015-05-06T08:18:32Z

src/main/groovy/com/github/jrubygradle/jar/JRubyJarPlugin.groovy

@@ -116,8 +69,51 @@ class JRubyJarPlugin implements Plugin<Project> {
        project.afterEvaluate {
            project.dependencies {
                jrubyJar group: 'org.jruby', name: 'jruby-complete', version: project.jruby.defaultVersion
+                // TODO remove hardcoded version to config
+                jrubyJar group: 'de.saumya.mojo', name: 'jruby-mains', version: '0.2.0'


We need to fix this after merge and before release.

rtyler · 2015-05-11T14:12:08Z

build.gradle

        transitive = false
    }
    testRepo ("org.spockframework:spock-core:0.7-groovy-2.0") {
        transitive = false
    }

-    testRepo 'com.github.jengelman.gradle.plugins:shadow:1.1.2'
-
-}


It looks like the removal of this final closing } ius causing the build to fail in Travis

* pack all jar-dependencies into root of the jar using a maven repository layout * use either main which runs completely from the jar or an extracting main which first extracts the jar into a temporary directory * shades both jruby-complete and jruby-mains into the executable jar using gradle zipTree, i.e. all shadowJar is gone * remove compat version and let jruby-mains pick .jrubyrc from the jar-file which can set the compat version when needed. (pending feature on jruby-mains) * init script support needs jruby-mains-0.1.1.jar released * generate .jrubydir files on resources added to jar Sponsored by Lookout Inc.

WIP create executable jar using jruby-main artifact

mkristian changed the title ~~create executable jar using jruby-main artifact~~ WIP create executable jar using jruby-main artifact Apr 18, 2015

ysb33r reviewed Apr 20, 2015
View reviewed changes

mkristian force-pushed the jruby-mains branch 3 times, most recently from fac5e43 to b94549e Compare May 1, 2015 20:46

mkristian reviewed May 1, 2015
View reviewed changes

mkristian force-pushed the jruby-mains branch from b94549e to 67aeef9 Compare May 5, 2015 16:58

ysb33r reviewed May 5, 2015
View reviewed changes

ysb33r mentioned this pull request May 5, 2015

TODO list for 0.1.4 #40

Closed

mkristian force-pushed the jruby-mains branch from 67aeef9 to 8dcf5b0 Compare May 5, 2015 22:38

ysb33r reviewed May 6, 2015
View reviewed changes

mkristian force-pushed the jruby-mains branch from 8dcf5b0 to 1aa6975 Compare May 7, 2015 19:41

rtyler reviewed May 11, 2015
View reviewed changes

mkristian force-pushed the jruby-mains branch from 1aa6975 to 3ec32c5 Compare May 11, 2015 14:37

mkristian force-pushed the jruby-mains branch from 3ec32c5 to aea1f7a Compare May 11, 2015 15:36

rtyler added this to the 0.1.4 milestone May 11, 2015

rtyler pushed a commit that referenced this pull request May 11, 2015

Merge pull request #38 from mkristian/jruby-mains

4b8de17

WIP create executable jar using jruby-main artifact

rtyler merged commit 4b8de17 into jruby-gradle:master May 11, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP create executable jar using jruby-main artifact #38

WIP create executable jar using jruby-main artifact #38

mkristian commented Apr 18, 2015

mkristian commented Apr 18, 2015

mkristian commented Apr 20, 2015

mkristian commented Apr 20, 2015

ysb33r Apr 20, 2015

mkristian Apr 21, 2015

mkristian Apr 28, 2015

ysb33r commented Apr 20, 2015

mkristian commented Apr 21, 2015

rtyler commented Apr 29, 2015

mkristian May 1, 2015

rtyler commented May 1, 2015

ysb33r May 5, 2015

ysb33r May 6, 2015

rtyler May 11, 2015

WIP create executable jar using jruby-main artifact #38

WIP create executable jar using jruby-main artifact #38

Conversation

mkristian commented Apr 18, 2015

mkristian commented Apr 18, 2015

mkristian commented Apr 20, 2015

mkristian commented Apr 20, 2015

ysb33r Apr 20, 2015

Choose a reason for hiding this comment

mkristian Apr 21, 2015

Choose a reason for hiding this comment

mkristian Apr 28, 2015

Choose a reason for hiding this comment

ysb33r commented Apr 20, 2015

mkristian commented Apr 21, 2015

rtyler commented Apr 29, 2015

mkristian May 1, 2015

Choose a reason for hiding this comment

rtyler commented May 1, 2015

ysb33r May 5, 2015

Choose a reason for hiding this comment

ysb33r May 6, 2015

Choose a reason for hiding this comment

rtyler May 11, 2015

Choose a reason for hiding this comment