Files missing from JRuby 1.7.5 #1138

Closed
cfbrobak opened this Issue Oct 17, 2013 · 7 comments

Projects

None yet

4 participants

@cfbrobak

jruby 1.7.5 (1.9.3p392) 2013-10-07 74e9291 on Java HotSpot(TM) Client VM 1.7.0_40-b43 [Windows XP-x86]

These files were all found in directory "bin/" in JRuby 1.7.4 but seem to be missing from JRuby 1.7.5:

  • ast.bat
  • jgem.bat
  • jrubyc
  • jrubyc.bat
  • jrubyw.exe
  • rake.bat
  • testrb.bat
@mkristian
Member

that is partially fixed by #1095

the remaining issue are the missing *bat files. they are just not in the git repo.

@enebo are they missing or does they get created when you prepare the windows installer ?

@enebo
Member
enebo commented Oct 17, 2013

core/src/main/ruby/jruby/commands.rb has generate_bat_stubs method which is
responsible for making these. Something in Maven move must have lost this
step. It is likely not run specifically for the windows installer but must
have been run for jruby-dist since I can see those .bat files in 1.7.4 bin
dist.

The jrubyw.exe is another issue altogether though. Windows installer
should have picked that up.

-Tom

On Thu, Oct 17, 2013 at 3:34 AM, Christian notifications@github.com wrote:

that is partially fixed by #1095#1095

the remaining issue are the missing *bat files. they are just not in the
git repo.

@enebo https://github.com/enebo are they missing or does they get
created when you prepare the windows installer ?

?
Reply to this email directly or view it on GitHubhttps://github.com/jruby/jruby/issues/1138#issuecomment-26487216
.

blog: http://blog.enebo.com twitter: tom_enebo
mail: tom.enebo@gmail.com

@enebo
Member
enebo commented Oct 17, 2013

Ohhhh no actually this is an issue with bin dist as well. jrubyw.exe is
not being put into bin dist so the new windows installation packager is
trying to include jrubyw.exe but it is not there.

-Tom

On Thu, Oct 17, 2013 at 9:20 AM, Thomas E Enebo tom.enebo@gmail.com wrote:

core/src/main/ruby/jruby/commands.rb has generate_bat_stubs method which
is responsible for making these. Something in Maven move must have lost
this step. It is likely not run specifically for the windows installer but
must have been run for jruby-dist since I can see those .bat files in 1.7.4
bin dist.

The jrubyw.exe is another issue altogether though. Windows installer
should have picked that up.

-Tom

On Thu, Oct 17, 2013 at 3:34 AM, Christian notifications@github.comwrote:

that is partially fixed by #1095#1095

the remaining issue are the missing *bat files. they are just not in the
git repo.

@enebo https://github.com/enebo are they missing or does they get
created when you prepare the windows installer ?


Reply to this email directly or view it on GitHubhttps://github.com/jruby/jruby/issues/1138#issuecomment-26487216
.

blog: http://blog.enebo.com twitter: tom_enebo
mail: tom.enebo@gmail.com

blog: http://blog.enebo.com twitter: tom_enebo
mail: tom.enebo@gmail.com

@enebo
Member
enebo commented Oct 17, 2013

heh 2d2daf5 fixed jrubyw.exe (e.g.
#1095). We just need the generate_bat_stubs run before jruby-dist starts
including bin/* files.

-Tom

On Thu, Oct 17, 2013 at 9:23 AM, Thomas E Enebo tom.enebo@gmail.com wrote:

Ohhhh no actually this is an issue with bin dist as well. jrubyw.exe is
not being put into bin dist so the new windows installation packager is
trying to include jrubyw.exe but it is not there.

-Tom

On Thu, Oct 17, 2013 at 9:20 AM, Thomas E Enebo tom.enebo@gmail.comwrote:

core/src/main/ruby/jruby/commands.rb has generate_bat_stubs method which
is responsible for making these. Something in Maven move must have lost
this step. It is likely not run specifically for the windows installer but
must have been run for jruby-dist since I can see those .bat files in 1.7.4
bin dist.

The jrubyw.exe is another issue altogether though. Windows installer
should have picked that up.

-Tom

On Thu, Oct 17, 2013 at 3:34 AM, Christian notifications@github.comwrote:

that is partially fixed by #1095#1095

the remaining issue are the missing *bat files. they are just not in the
git repo.

@enebo https://github.com/enebo are they missing or does they get
created when you prepare the windows installer ?


Reply to this email directly or view it on GitHubhttps://github.com/jruby/jruby/issues/1138#issuecomment-26487216
.

blog: http://blog.enebo.com twitter: tom_enebo
mail: tom.enebo@gmail.com

blog: http://blog.enebo.com twitter: tom_enebo
mail: tom.enebo@gmail.com

blog: http://blog.enebo.com twitter: tom_enebo
mail: tom.enebo@gmail.com

@mkristian
Member

I am on the command.rb one - I guess ;)

@headius
Member
headius commented Oct 21, 2013

Status on this? 1.7.6 is right around the corner.

@enebo
Member
enebo commented Oct 22, 2013

I believe we got them all now. Closing

@enebo enebo closed this Oct 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment