/jruby

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test coerce2 #5006

Merged
merged 4 commits into from Jan 24, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
  JRuby 9.1.16.0
2 participants
@yui-knk @enebo
@yui-knk
Contributor

yui-knk commented Jan 24, 2018

No description provided.

yui-knk added some commits Jan 24, 2018

@yui-knk
Define `Numeric#%` 
Currently `Numeric#%` is defined in the same way
as `Numeric#modulo`.

Ref: https://github.com/ruby/ruby/blob/v2_3_0/numeric.c#L4179-L4180
c4957fc
@yui-knk
Remove `Rational#modulo` and `Rational#%` 
Currently these methods are not defined on `Rational`.
6edca41
@yui-knk
Remove `Rational#div` 
Currently this method is not defined on `Rational`.
a559b81
@yui-knk
Add `#test_coerce2` to test targets 
Now `test_coerce2` does not fail.
ad9b482

@enebo enebo added this to the JRuby 9.1.16.0 milestone Jan 24, 2018

@enebo enebo added the core label Jan 24, 2018

@enebo

This comment has been minimized.

Sign in to view
Member

enebo commented Jan 24, 2018

@yui-knk just waiting for test:mri to finish and this looks good. Weirded out that '.div' is no longer there but I see it is not in Ruby docs for 2.2? I don't know the history of that merthod though.
@yui-knk

This comment has been minimized.

Sign in to view
Contributor

yui-knk commented Jan 24, 2018

Maybe ruby/ruby@d82ed7e this commit removed Rational#div and this commit was included Ruby 1.9.2, so I think Ruby docs for 2.2 should not contain that method.
I can not read why this method was removed by the commit message....
@enebo

This comment has been minimized.

Sign in to view
Member

enebo commented Jan 24, 2018

@yui-knk yeah it is strange to see Ruby API shrink :)

@enebo enebo merged commit 6b375fd into jruby:jruby-9.1 Jan 24, 2018
1 check was pending

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@yui-knk yui-knk deleted the yui-knk:fix_test_coerce2 branch Jan 24, 2018

@yui-knk yui-knk referenced this pull request Jan 31, 2018

Merged

Fix test coerce2 for master branch #5022

kares added a commit that referenced this pull request Jan 31, 2018

@kares
Merge pull request #5022 from yui-knk/fix_test_coerce2_master 
Fix test coerce2 for master branch

since merge of #5006 wasn't handled properly due changes in RubyRational.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
0c00708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment