New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test coerce2 for master branch #5022

Merged
merged 3 commits into from Jan 31, 2018

Conversation

Projects
None yet
2 participants
@yui-knk
Contributor

yui-knk commented Jan 31, 2018

This PR is porting of #5006.
Method names modulo19, op_idiv19 and op_mod19 have been changed on master branch.
So we should porting the commit manually.
I hope this PR fix "test:mri*".

yui-knk added some commits Jan 31, 2018

Define `Numeric#%`
Currently `Numeric#%` is defined in the same way
as `Numeric#modulo`.

Ref: https://github.com/ruby/ruby/blob/v2_4_0/numeric.c#L5240-L5241
Remove `Rational#modulo` and `Rational#%`
Currently these methods are not defined on `Rational`.
Remove `Rational#div`
Currently this method is not defined on `Rational`.

@yui-knk yui-knk referenced this pull request Jan 31, 2018

Merged

Fix `convertCommon` #5010

@kares

This comment has been minimized.

Member

kares commented Jan 31, 2018

Thanks Yui, indeed resolves the issue. #5006 was merged over from 9.1 so I wonder what happened.
... guess this is why the whole thing was confusing and seemed like smt must have regressed

@kares

This comment has been minimized.

Member

kares commented Jan 31, 2018

think the jruby-9.1 merge must have had conflicts at RubyRational.java and wasn't resolved properly

@kares kares merged commit 0c00708 into jruby:master Jan 31, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@kares kares added this to the JRuby 9.2.0.0 milestone Jan 31, 2018

@yui-knk yui-knk deleted the yui-knk:fix_test_coerce2_master branch Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment