Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rspec test cases for mutex 'sleep' #962

Closed
wants to merge 1 commit into from
Closed

rspec test cases for mutex 'sleep' #962

wants to merge 1 commit into from

Conversation

rajcybage
Copy link
Contributor

I saw that there was test cases for synchronize,lock,unlock but not for sleep
I have implemented some rspec test cases for the 'sleep' method of Mutex.

Also use expect rather than should
Thanks

@rajcybage
Copy link
Contributor Author

cc @headius @enebo @BanzaiMan

@BanzaiMan
Copy link
Member

This should go to our rubyspec repo (https://github.com/jruby/rubyspec). Please re-create it there.

@BanzaiMan BanzaiMan closed this Aug 20, 2013
@rajcybage
Copy link
Contributor Author

There has already sleep_spec.rb for mutex but not present in our jruby specs.

I have one more question as we upgrade our rspec to 2.14 so can we use expect instead of should method http://betterspecs.org/#expect.
Please look into #966

This is just a suggestion

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants