Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures DSL files get loaded, even when within jar, called from java #27

Merged
merged 1 commit into from
Feb 10, 2013

Conversation

edubkendo
Copy link
Member

class.

Got to the bottom of #24. I checked on what the value of the rt variable in dsl.rb was, in the case that you try to launch a jrubyfx app from java using the embedding api and found out that it was getting set to:

jar:file:/home/eric/projects/jrubyfx_projects/jrubyfx_web/hello.jar!/gems/jrubyfx-0.9.2-java/lib/jrubyfx/core_ext

And Dir.glob seemed to be choking on that jar: at the beginning. So, just added a regex that would remove that if it was at the start and otherwise would leave it as is. Ran the new specs and the run_all_samples which were still fine.

@edubkendo
Copy link
Member Author

Sorry about changing all those lines, btw, just realized my editor , which is set to trim all whitespace, must have done that. I can re-do this if needed.

@byteit101
Copy link
Member

no thats fine, look at some of my recent commits :)

byteit101 added a commit that referenced this pull request Feb 10, 2013
Ensures DSL files get loaded, even when within jar, called from java
@byteit101 byteit101 merged commit f543b17 into jruby:master Feb 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants