Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrictions for python version #17

Open
andrejchenko opened this issue May 14, 2021 · 7 comments
Open

Restrictions for python version #17

andrejchenko opened this issue May 14, 2021 · 7 comments

Comments

@andrejchenko
Copy link

Dear Cddd team,

We noticed that with the python restrictions you've added to your repo:
python_requires='>=3.6.1, <3.7'
https://github.com/jrwnter/cddd/blame/cc0fd9a3dea4373bf5b69ac9be5c1c5511bcbfcb/setup.py#L15
we cannot create conda environments with newer python versions >=3.7.9.
image

While with the older cddd version we were able to do this.
I wonder why was this restriction added in the first place?
Could you make the repo to be compatible with newer python versions?

Thank you in advance!

@jrwnter
Copy link
Owner

jrwnter commented May 17, 2021

Hi, thanks for reaching out. We included this restriction for the rollout of cddd to pypi. CDDD depends on tensorflow 1.10 which depends on python < 3.7. Did you use a different tensorflow version in your environment?

@andrejchenko
Copy link
Author

I used tensorflow=1.15.2, since I received errors when creating a conda enviroment with tensorflow=1.10.
Cddd with tensorflow=1.15.2 worked.

@j3mdamas
Copy link

@jrwnter Is there interest in upgrading this package? I was working on a clone of this with modern versions of Python and other packages, and I was wondering if that's of interest

@jrwnter
Copy link
Owner

jrwnter commented Nov 22, 2023

Sure. The question is, if the new version can run the old model file. If not, we would need to retrain and cross our fingers that the model achieves the same downstream performance...

@j3mdamas
Copy link

I see your point, I totally missed that. When I come back to you, I may give it a try to see if I can run the old model file. Thanks for the answer.

@andre-stadelmann
Copy link

I would be interested in an upgraded version of this package. Is this something you are still working on @j3mdamas?

I could also be interested in helping out in retraining and validating the models if we would need to retrain for TF2 @jrwnter. It would be a shame if this project goes to waste due to new hardware no longer supporting CUDA 10.

@j3mdamas
Copy link

j3mdamas commented Mar 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants