fix: addressed interfaces issues

mariocoski · mariocoski · commit c369a94a4c3b · 2019-08-25T23:09:05.000+01:00
diff --git a/dist/errors/conflictingItemError.d.ts b/dist/errors/conflictingItemError.d.ts
@@ -1,6 +1,6 @@
 import { BaseError } from "make-error";
 export default class ConflictingItemError extends BaseError {
     readonly itemName: string;
-    readonly itemId: string;
-    constructor(itemName: string, itemId: string);
+    readonly itemId?: string;
+    constructor(itemName: string, itemId?: string);
 }
diff --git a/dist/errors/conflictingItemError.js.map b/dist/errors/conflictingItemError.js.map
diff --git a/dist/errors/itemNotFoundError.d.ts b/dist/errors/itemNotFoundError.d.ts
@@ -1,6 +1,6 @@
 import { BaseError } from "make-error";
 export default class ItemNotFoundError extends BaseError {
     readonly itemName: string;
-    readonly itemId: string;
-    constructor(itemName: string, itemId: string);
+    readonly itemId?: string;
+    constructor(itemName: string, itemId?: string);
 }
diff --git a/dist/errors/itemNotFoundError.js.map b/dist/errors/itemNotFoundError.js.map
diff --git a/dist/facade.d.ts b/dist/facade.d.ts
@@ -8,7 +8,7 @@ import ReplaceItem from "./functions/ReplaceItem";
 import UpdateItem from "./functions/UpdateItem";
 import Item from "./interfaces/Item";
 export default interface Facade<I extends Item> {
-    readonly countItems: CountItems<I>;
+    readonly countItems?: CountItems<I>;
     readonly createItem: CreateItem<I>;
     readonly getItem: GetItem<I>;
     readonly getItems: GetItems<I>;
diff --git a/dist/functions/countItems/test.d.ts b/dist/functions/countItems/test.d.ts
@@ -1,4 +1,4 @@
-import Options from "../../interfaces/Options";
-import { TestItem } from "../utils/testItem";
+import Options from '../../interfaces/Options';
+import { TestItem } from '../utils/testItem';
 declare const _default: ({ facade }: Options<TestItem>) => void;
 export default _default;
diff --git a/dist/functions/countItems/test.js b/dist/functions/countItems/test.js
diff --git a/dist/functions/countItems/test.js.map b/dist/functions/countItems/test.js.map
diff --git a/dist/functions/createItem/index.d.ts b/dist/functions/createItem/index.d.ts
@@ -1,6 +1,6 @@
 import Item from '../../interfaces/Item';
 export interface Options<I extends Item> {
-    readonly id: string;
+    readonly id?: string;
     readonly item: I;
 }
 export interface Result<I extends Item> {
diff --git a/dist/testFacade.d.ts b/dist/testFacade.d.ts
@@ -1,4 +1,4 @@
-import { TestItem } from "./functions/utils/testItem";
-import Options from "./interfaces/Options";
+import { TestItem } from './functions/utils/testItem';
+import Options from './interfaces/Options';
 declare const _default: (options: Options<TestItem>) => void;
 export default _default;
diff --git a/dist/testFacade.js b/dist/testFacade.js
diff --git a/dist/testFacade.js.map b/dist/testFacade.js.map
diff --git a/src/Facade.ts b/src/Facade.ts
@@ -9,7 +9,7 @@ import UpdateItem from "./functions/UpdateItem";
 import Item from "./interfaces/Item";
 
 export default interface Facade<I extends Item> {
-  readonly countItems: CountItems<I>;
+  readonly countItems?: CountItems<I>;
   readonly createItem: CreateItem<I>;
   readonly getItem: GetItem<I>;
   readonly getItems: GetItems<I>;
diff --git a/src/errors/ConflictingItemError.ts b/src/errors/ConflictingItemError.ts
@@ -3,9 +3,9 @@ import { BaseError } from "make-error";
 export default class ConflictingItemError extends BaseError {
 
   public readonly itemName: string;
-  public readonly itemId: string;
+  public readonly itemId?: string;
   
-  public constructor(itemName: string, itemId: string){
+  public constructor(itemName: string, itemId?: string){
     super();
     this.itemName = itemName;
     this.itemId = itemId;
diff --git a/src/errors/ItemNotFoundError.ts b/src/errors/ItemNotFoundError.ts
@@ -3,9 +3,9 @@ import { BaseError } from "make-error";
 export default class ItemNotFoundError extends BaseError {
 
   public readonly itemName: string;
-  public readonly itemId: string;
+  public readonly itemId?: string;
   
-  public constructor(itemName: string, itemId: string){
+  public constructor(itemName: string, itemId?: string){
     super();
     this.itemName = itemName;
     this.itemId = itemId;
diff --git a/src/functions/CountItems/test.ts b/src/functions/CountItems/test.ts
@@ -1,31 +1,34 @@
-import Options from "../../interfaces/Options";
-import { TestItem } from "../utils/testItem";
-import testUsingFilter from "../utils/testUsingFilter";
+// tslint:disable:no-any
+import Options from '../../interfaces/Options';
+import { TestItem } from '../utils/testItem';
+import testUsingFilter from '../utils/testUsingFilter';
 
 export default ({ facade }: Options<TestItem>) => {
-  describe("countItems", () => {
-    testUsingFilter({
-      facade,
-      toGetAllItems: async filter => {
-        const { count } = await facade.countItems({ filter });
-        const expectedCount = 2;
-        expect(count).toBe(expectedCount);
-      },
-      toGetFirstItem: async filter => {
-        const { count } = await facade.countItems({ filter });
-        const expectedCount = 1;
-        expect(count).toBe(expectedCount);
-      },
-      toGetNoItems: async filter => {
-        const { count } = await facade.countItems({ filter });
-        const expectedCount = 0;
-        expect(count).toBe(expectedCount);
-      },
-      toGetSecondItem: async filter => {
-        const { count } = await facade.countItems({ filter });
-        const expectedCount = 1;
-        expect(count).toBe(expectedCount);
-      }
+  if (facade.countItems !== undefined) {
+    describe('countItems', () => {
+      testUsingFilter({
+        facade,
+        toGetAllItems: async filter => {
+          const { count } = await (facade as any).countItems({ filter });
+          const expectedCount = 2;
+          expect(count).toBe(expectedCount);
+        },
+        toGetFirstItem: async filter => {
+          const { count } = await (facade as any).countItems({ filter });
+          const expectedCount = 1;
+          expect(count).toBe(expectedCount);
+        },
+        toGetNoItems: async filter => {
+          const { count } = await (facade as any).countItems({ filter });
+          const expectedCount = 0;
+          expect(count).toBe(expectedCount);
+        },
+        toGetSecondItem: async filter => {
+          const { count } = await (facade as any).countItems({ filter });
+          const expectedCount = 1;
+          expect(count).toBe(expectedCount);
+        },
+      });
     });
-  });
+  }
 };
diff --git a/src/functions/CreateItem/index.ts b/src/functions/CreateItem/index.ts
@@ -1,7 +1,7 @@
 import Item from '../../interfaces/Item';
 
 export interface Options<I extends Item> {
-  readonly id: string;
+  readonly id?: string;
   readonly item: I;
 }
 
diff --git a/src/testFacade.ts b/src/testFacade.ts
@@ -1,21 +1,22 @@
-import testCountItems from "./functions/CountItems/test";
-import testCreateItem from "./functions/CreateItem/test";
-import testDeleteItem from "./functions/DeleteItem/test";
-import testDeleteItems from "./functions/DeleteItems/test";
-import testGetItem from "./functions/GetItem/test";
-import testGetItems from "./functions/GetItems/test";
-import testReplaceItem from "./functions/ReplaceItem/test";
-import testUpdateItem from "./functions/UpdateItem/test";
-import { TestItem } from "./functions/utils/testItem";
-import Options from "./interfaces/Options";
+import testCountItems from './functions/CountItems/test';
+import testCreateItem from './functions/CreateItem/test';
+import testDeleteItem from './functions/DeleteItem/test';
+import testDeleteItems from './functions/DeleteItems/test';
+import testGetItem from './functions/GetItem/test';
+import testGetItems from './functions/GetItems/test';
+import testReplaceItem from './functions/ReplaceItem/test';
+import testUpdateItem from './functions/UpdateItem/test';
+import { TestItem } from './functions/utils/testItem';
+import Options from './interfaces/Options';
 
 export default (options: Options<TestItem>) => {
-  describe("testFacade", () => {
+  describe('testFacade', () => {
     beforeEach(async () => {
       await options.facade.deleteItems({ filter: {} });
     });
-
-    testCountItems(options);
+    if (options.facade.countItems !== undefined) {
+      testCountItems(options);
+    }
     testCreateItem(options);
     testDeleteItem(options);
     testDeleteItems(options);

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`import { BaseError } from "make-error";`
`2`	`2`	`export default class ConflictingItemError extends BaseError {`
`3`	`3`	`readonly itemName: string;`
`4`		`- readonly itemId: string;`
`5`		`- constructor(itemName: string, itemId: string);`
	`4`	`+ readonly itemId?: string;`
	`5`	`+ constructor(itemName: string, itemId?: string);`
`6`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`import { BaseError } from "make-error";`
`2`	`2`	`export default class ItemNotFoundError extends BaseError {`
`3`	`3`	`readonly itemName: string;`
`4`		`- readonly itemId: string;`
`5`		`- constructor(itemName: string, itemId: string);`
	`4`	`+ readonly itemId?: string;`
	`5`	`+ constructor(itemName: string, itemId?: string);`
`6`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`import Item from '../../interfaces/Item';`
`2`	`2`	`export interface Options<I extends Item> {`
`3`		`- readonly id: string;`
	`3`	`+ readonly id?: string;`
`4`	`4`	`readonly item: I;`
`5`	`5`	`}`
`6`	`6`	`export interface Result<I extends Item> {`