Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ulti.js.org #7076

Merged
merged 1 commit into from
Mar 25, 2022
Merged

ulti.js.org #7076

merged 1 commit into from
Mar 25, 2022

Conversation

UltiRequiem
Copy link
Contributor

As talked about on #7073

As talked about on #7073
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance ulti.js.org.


It also looks like this site is currently set up to redirect elsewhere, which js.org does not permit.

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Mar 24, 2022
@UltiRequiem
Copy link
Contributor Author

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository).

Done
https://github.com/UltiRequiem/ultirequiem.github.io/blob/main/CNAME

It also looks like this site is currently set up to redirect elsewhere, which js.org does not permit.

Oh, it's because I previously used it as my webpage but since some time ago I have a custom domain. If it's not a redirector I'm not sure what to put there. A 404 would be Ok?

@indus
Copy link
Member

indus commented Mar 24, 2022

@UltiRequiem It think we talked about a landing page that features your library collection.

@indus indus added discussion and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Mar 24, 2022
@UltiRequiem
Copy link
Contributor Author

https://github.com/UltiRequiem/ultirequiem.github.io/tree/ulti.js.org

image

Done!

@UltiRequiem It think we talked about a landing page that features your library collection.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/UltiRequiem/ultirequiem.github.io/tree/ulti.js.org

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account and removed discussion labels Mar 25, 2022
@indus
Copy link
Member

indus commented Mar 25, 2022

@indus indus merged commit 95e7f9b into js-org:master Mar 25, 2022
@MattIPv4 MattIPv4 mentioned this pull request Mar 30, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants