Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crawlyx.js.org #8217

Merged
merged 3 commits into from
May 5, 2023
Merged

crawlyx.js.org #8217

merged 3 commits into from
May 5, 2023

Conversation

theritikchoure
Copy link
Contributor

Project - https://github.com/theritikchoure/crawlyx/
CNAME - https://github.com/theritikchoure/crawlyx/blob/main/docs/CNAME

@MattIPv4 MattIPv4 changed the title Update cnames_active.js crawlyx.js.org May 2, 2023
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ The site you have linked to for your js.org domain request returns a 404: https://theritikchoure.github.io/crawlyx/
Please fix this before we can process your js.org domain request. 🛠

@MattIPv4 MattIPv4 added the 404 The page requested returns a 404 response label May 2, 2023
@theritikchoure
Copy link
Contributor Author

Url updated. Now you can verify it.

Thanks

@indus
Copy link
Member

indus commented May 2, 2023

@theritikchoure There is no way to deep-link into a repository. You will have to make the page available at https://theritikchoure.github.io/crawlyx to make it work.

@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels May 2, 2023
@indus
Copy link
Member

indus commented May 4, 2023

@theritikchoure any updates?

@theritikchoure
Copy link
Contributor Author

I have one more domain from 'js.org for my carrierjs package. In that repository, I have did the same thing as now.

@indus
Copy link
Member

indus commented May 5, 2023

I have one more domain from 'js.org for my carrierjs package. In that repository, I have did the same thing as now.

It looks like you havn't made the setting in this repo that makes the docs folder to the root of the page.
FYI: https://help.github.com/articles/configuring-a-publishing-source-for-github-pages (with workflows other steps may be required)

As I said https://theritikchoure.github.io/crawlyx has to return a page. Otherwise I can't process this request.

@theritikchoure
Copy link
Contributor Author

Ok I have updated page setting

@indus indus removed the 404 The page requested returns a 404 response label May 5, 2023
@indus
Copy link
Member

indus commented May 5, 2023

Welcome https://crawlyx.js.org

@indus indus merged commit 2cec42b into js-org:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants