Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs.uaparser.js.org #8509

Merged
merged 2 commits into from
Sep 14, 2023
Merged

docs.uaparser.js.org #8509

merged 2 commits into from
Sep 14, 2023

Conversation

faisalman
Copy link
Contributor

@MattIPv4
Copy link
Member

cc #8508

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/faisalman/ua-parser-js-docs/tree/gh-pages/docs/v2

@MattIPv4
Copy link
Member

(You might want an index.html that redirects the user to /v2, otherwise the site will show as a 404 at the root of the subdomain I think?)

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Sep 14, 2023
@indus
Copy link
Member

indus commented Sep 14, 2023

Welcome http://docs.uaparser.js.org/v2/
(you should definatly add a inde.html to the root; otherwise everytime we make a cleanup and check all the pages for existance you will get notified because of the 404; also it looks like there is a path issue now)

@indus indus merged commit 35b126f into js-org:master Sep 14, 2023
1 check passed
@faisalman
Copy link
Contributor Author

Welcome http://docs.uaparser.js.org/v2/ (you should definatly add a inde.html to the root; otherwise everytime we make a cleanup and check all the pages for existance you will get notified because of the 404; also it looks like there is a path issue now)

Noted! Thanks 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants