Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micanto.js.org #9002

Merged
merged 1 commit into from
May 8, 2024
Merged

micanto.js.org #9002

merged 1 commit into from
May 8, 2024

Conversation

andreknieriem
Copy link
Contributor

@MattIPv4 MattIPv4 changed the title Update cnames_active.js micanto.js.org May 8, 2024
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/micanto-music/micanto looks to be a PHP project. How is this directly related to the JavaScript ecosystem/community?

@MattIPv4 MattIPv4 added the awaiting response This PR is waiting for a response from the requester label May 8, 2024
@andreknieriem
Copy link
Contributor Author

Hey. It is a react webapp with a laravel php backend. And it comes with an react native android app too. So it is basically javascript for frontends and an php api backend.

@MattIPv4
Copy link
Member

MattIPv4 commented May 8, 2024

I see. @indus what do you think? This feels to me a bit like one of those situations where "websites are built with JavaScript, but that doesn't make them directly related"?

@indus indus removed the awaiting response This PR is waiting for a response from the requester label May 8, 2024
@indus
Copy link
Member

indus commented May 8, 2024

@MattIPv4 Hm - another difficult case. I find the "every website uses JS" explanation less appropriate here. The frontend component would easily qualify. It's more the fact that the documentation is mainly about the setup of the backend.
However, due to the frontend, I tend to accept the request.

Welcome https://micanto.js.org/

@andreknieriem To give the page more relevance in terms of JavaScript, I would like to see a prominent link to the app component in the documentation if possible

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account labels May 8, 2024
@indus indus merged commit 3a03a8d into js-org:master May 8, 2024
1 check passed
@andreknieriem
Copy link
Contributor Author

Thanks! I will update my readme the next days. There will be a whole documentation about everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants