Split the building blocks into separate source files #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2014 15:53
Although each piece is also exposed via the default require, the building blocks can be useful on their own and shouldn't necessitate including all of the module.
nikcorg
changed the title
laurisvan
added a commit
that referenced
this pull request
Dec 2, 2014
Split the building blocks into separate source files
|
Works for me alright. Actually, I was thinking about splitting away the config reading part - it's probably better as its own module altogether... |
|
I agree, but since you have a util-module, extracting it is negligible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely, this PR splits up the monolithic
lib/indexinto discrete files which can be required on their own. This, because I see them as being useful on their own, and there is really no reason to necessitate requiring the entire module when you need only a quarter of it. Also, I find it makes the code easier to read (and hopefully maintain), but that's just my opinion.Unfortunately, for some reason,
jsdoc2mddidn't want to play along with me and thus the documentation is not up to date.