fix: repository...

- add travis-ci and coverage
- some refactoring
- added missing tests

closes #1.

Author: diasbruno

.gitignore

@@ -2,3 +2,6 @@ lib/*
 node_modules/**
 yarn.lock
 package-lock.json
+builder/**
+coverage/**
+.nyc_output/**

.travis.yml

@@ -0,0 +1,14 @@
+language: node_js
+node_js:
+  - "7"
+cache:
+  yarn: true
+
+install:
+  - yarn install
+
+script:
+  - REPORT=lcov make test
+
+after_success:
+  - cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage

Makefile

@@ -17,9 +17,6 @@ dist-all: pre-build dist/range.js dist/range.min.js lib/range.js
 
 all: test dist-all lib/range.js
 
-test:
-	$(MOCHA) $(TEST_CFLAGS) tests/*.js
-
 clean:
 	rm -rf lib dist
 

builder

@@ -16,7 +16,15 @@
     "babel-preset-es2015": "^6.24.1",
     "babel-preset-stage-0": "^6.24.1",
     "babel-register": "^6.26.0",
+    "coveralls": "^2.13.1",
+    "istanbul": "^0.4.5",
     "mocha": "^3.5.0",
+    "nyc": "^11.2.1",
     "should": "^12.0.0"
+  },
+  "nyc": {
+    "exclude": [
+      "tests/*.js"
+    ]
   }
 }

package.json

@@ -11,9 +11,9 @@ export const rangeIn = (start, end, range) =>
 
 export const rangeImpl = (start, end, step, f) => {
   const length = end - start;
-  const elements = step > 1 ?
-      (length - (step == 1 ? 0 : Math.round(length / step))) :
-      Math.round(length / step);
+  if (length == 0 || step == 0) { return []; }
+  const steps = Math.round(length / step);
+  const elements = step > 1 ? (length - steps) : steps;
   const ls = new Array(elements);
   for (let i = 0; i < length && i <= elements; i++) {
     ls[i] = f((i * step) + start);
@@ -27,7 +27,7 @@ export const rangeChar = (start, end) => {
   let ok = rangeIn(x, y, charLowerRange) ||
       rangeIn(x, y, charUpperRange) ||
       rangeIn(x, y, charNumberRange);
-  return ok ? rangeImpl( x, y + 1, 1, String.fromCharCode) : [];
+  return ok ? rangeImpl(x, y + 1, 1, String.fromCharCode) : [];
 };
 
 export const rangeStep = (start, end, step) =>

src/index.js

@@ -4,7 +4,7 @@ import * as R from '../src/index.js';
 
 describe("range", () => {
   context("numeric", () => {
-    it("empty range.", () => {
+    it("zero range.", () => {
       R.range(0, 0).should.be.eql([]);
     });
 
@@ -34,6 +34,14 @@ describe("range", () => {
       it("[1..10), 2", () => {
         R.rangeStep(1, 10, 2).length.should.be.eql(5);
       });
+
+      it("[1..10]", () => {
+        R.rangeInclStep(1, 10, 2).length.should.be.eql(6);
+      });
+
+      it("zero step should return empty list.", () => {
+        R.rangeImpl(1, 1, 0).should.be.eql([]);
+      });
     });
   });