Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support conversion of non-app actions #50

Closed
js07 opened this issue Apr 20, 2023 · 1 comment
Closed

Support conversion of non-app actions #50

js07 opened this issue Apr 20, 2023 · 1 comment
Assignees
@js07
Labels
enhancement New feature or request

Comments

@js07
Copy link
Owner

js07 commented Apr 20, 2023

Currently, legacy actions must include a namespace, title, description, version, code_config, code_raw, and hashId to be converted to a component action.

Support converting legacy actions from only the code_raw so that code steps in workflows can be converted using only the code. Allow the other parameters to be optional.
@js07 js07 added the enhancement New feature or request label Apr 20, 2023
@js07 js07 self-assigned this Apr 21, 2023
@js07 js07 mentioned this issue Apr 25, 2023
Merged
js07 added a commit that referenced this issue Apr 25, 2023
@js07
feat: conversion of code step actions (#51)
4fba1d8 
* feat: require only raw code for conversion

Makes optional: HID, DEFAULT_NAMESPACE, TITLE, DESCRIPTION,
PUBLISHED_VERSION_MAJOR, PUBLISHED_VERSION_MINOR, CODE_CONFIG_JSON

Generated components may now omit properties: key, type, name,
description, version, props

* fix: incorrect var name key -> paramKey

* parse params from raw code if code config or params schema is omitted

* make optional - fix using Pipedream eslint rules

Partially addresses: #50
@js07 js07 mentioned this issue May 1, 2023
Merged
@js07
Copy link
Owner Author

js07 commented May 2, 2023

Resolved by #51 & #52

@js07 js07 closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@js07 js07

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@js07