Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs to be more obvious how to install from source #15

Closed
aspiers opened this issue Jun 10, 2020 · 3 comments · Fixed by #27
Closed

Needs to be more obvious how to install from source #15

aspiers opened this issue Jun 10, 2020 · 3 comments · Fixed by #27

Comments

@aspiers
Copy link

aspiers commented Jun 10, 2020

Currently the installation instructions only explain how to install from a release tarball. This has a few issues:

  • It won't attract developers to contribute to the project, which is a shame, because it seems significantly better than the "official" prettier/prettier-emacs in many ways and therefore deserves greater popularity.
  • It doesn't allow installation from latest master, thereby turning the release process into a potential bottleneck.
  • It promotes a low bus factor.
  • Lack of clarity over the build process leads to questions like Why can't you package this up and publish on Melpa? #11.

While writing this issue, I accidentally found HACKING.md which provides the missing info - awesome! However this is not linked from README.md, so it would be great to add that link to make it easier to find :-)

@jscheid
Copy link
Owner

jscheid commented Jun 10, 2020

All good points. HACKING.md is probably outdated, I should check the instructions to make sure it's still good advice. Linking it into README is a good idea.

Note that I've been doing some experiments around VM-based builds over in the melpa branch. I'm not too fond of it but it might be useful as a stop-gap, and help illuminate the--admittedly--currently quite arcane build process.

@aspiers
Copy link
Author

aspiers commented Jun 10, 2020

Thanks for the reply. I finally got this mode working using the melpa branch from #13, after some trial and error. Another gotcha I fell into was having prettier-el-home set to an older quelpa build directory which no longer existed. As a result it was failing to find the blob. When I updated the variable it worked fine.

@aspiers
Copy link
Author

aspiers commented Jun 10, 2020

I'm now using this approach:

(defvar prettier-el-home "~/.GIT/3rd-party/prettier.el")

(if (file-directory-p prettier-el-home)
    (use-package prettier
      :load-path prettier-el-home)
  (warn "%s did not exist; won't install prettier.el"))

which works nicely after #19 is applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants