s3boto modified_time fails for new file

[caffodian]

This isn't actually my fix - I stumbled across it when trying to debug an issue with Mezzanine's usage of Django-Storages and involves a case where last_modified is not set for newly uploaded files.

https://bitbucket.org/david/django-storages/issue/163/s3boto-modified_time-fails-for-new-file

The PR towards original django-storages that I borrowed this fix from... seems like it's over a year old and never merged.

https://bitbucket.org/david/django-storages/pull-request/96/if-entrylast_modified-is-none-set-to/diff

[jschneier]

Hello and thanks for your contribution. Just from reading the bug report on the original repo this only occurs when AWS_PRELOAD_METADATA=True right? I need a little bit of time to familiarize myself with the ramifications of that setting before I merge this but I'll get to that ASAP.

[caffodian]

Yea, I believe this only applies to that case. The entry will exist but it will try to parse the None timestamp and die if you call modified_time on a new file.

Sorry for the lack of an actual repro test case or anything at the moment - I stumbled across this repo when trying to get storages to work with a newer version of boto, and this was a fix I'd found while getting mezzanine's filebrowser working on s3. Will be glad to help out once holiday madness dies down ;)

[jschneier]

I think this was very close. Have a look at #14.

[jschneier]

Just merged mine in and closing this. Thanks for the inspiration and the bug report!

[caffodian]

thanks for the fix! Looks like it should work and I'll give it a shot with my particular issue when I'm back in the office after the holidays. Hopefully I have a more meaningful contribution next time around ;)