Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes and additions for numbers #358

Merged
merged 13 commits into from
May 16, 2020

Conversation

vlad-km
Copy link
Member

@vlad-km vlad-km commented May 16, 2020

  1. utils.lisp
    Fixed integer-to-string for corrected parse bignumber. Current function with mod, parsed (expt 10 65) as:
CL-USER> (expt 10 65)
10000000000000000000000NIL00000000000000000000000000000000000000NIL000
CL-USER>  

Path fixed it. Now (expt 10 65) parsed as

CL-USER> (expt 10 65)
100000000000000000000008244226848602684002400884060400424240244468
  1. codegenerator.lisp
    Fixed incorrect binary-op string for compilation ASH function (shift right)

  2. compiler.lisp
    Added implementation of the next standard functions: ASH, LOGAND, LOGXOR, LOGNOT.
    Function LOGIOR not released. The reason for this, is the birth trauma of the reader; it incorrectly reads the symbol | at compilation. There are no ideas how to fix it, and whether it is necessary to fix it. Maybe later, somehow...

  3. Test cases added.

@davazp
Copy link
Member

davazp commented May 16, 2020

Looks great as always 👍

@davazp davazp merged commit 84d6437 into jscl-project:master May 16, 2020
@vlad-km vlad-km deleted the vkm-numbers-051520 branch May 13, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants