Save all the contents of the reporter to the file not just the ultimate console.log statement. #22
Conversation
|
@markelog, what do you think about this? |
| @@ -287,6 +287,8 @@ module.exports = { | |||
| jscs.setErrors( errorsCollection ).report(); | |||
|
|
|||
| test.ok( grunt.file.exists( "test.xml" ), "test.xml should exist" ); | |||
| test.notEqual( grunt.file.read( "test.xml" ), "</checkstyle>\n", | |||
There was a problem hiding this comment.
test.xml it was just a typo and I fixed it over in my repo https://github.com/solenoid/grunt-jscs-checker/commit/134f48ae416fbaae177a92c494e643c2bb9c9bb0
I'll try and update this pull request if I can but I can't tell if it is github's issues right now or some issue on how I did the pull request to bring that typo fix commit in here.
|
Fix the missing comma and squash the commits and I'll merge! |
…te console.log statement.
|
All fixed, and once merged I'll have another pull request coming to fix jshint to be recursive and then also try and fix all the issues missed because it is only one level deep for tasks. |
Save all the contents of the reporter to the file not just the ultimate console.log statement.
|
@solenoid, @gustavohenke sorry for the late response, holidays finely got to me, PR looks great now, good catch. @gustavohenke since we on the subject, how about following git conventions? |
|
It seems good, @markelog. Let's follow these conventions. |
|
@solenoid Released in NPM, v0.3.1 |
|
@gustavohenke thanks! v0.3.1 works like a charm and glad to see the jscs version bump too. Glad to see the updated conventions and new work will follow them. |
No description provided.