Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Fix field in rule declaration #1113

Closed
markelog opened this issue Feb 24, 2015 · 3 comments
Closed

Fix field in rule declaration #1113

markelog opened this issue Feb 24, 2015 · 3 comments
Labels

Comments

@markelog
Copy link
Member

See discussion in #1087 (comment)

@markelog
Copy link
Member Author

@mrjoelkemp @zxqfox @mikesherov @mdevils would like some reaction to this, there is some rules that could not be used with basic assertions without bloating amount of functions for this module.

@mikesherov
Copy link
Contributor

@markelog want to talk about it after 1.12 is out. Sorry for delaying discussion, just have lots going on.

@qfox
Copy link
Member

qfox commented Apr 8, 2015

Sorry for delay, guys.

But there doesn't seem to be many other needs for additional assertions, and I think the fear of an overblown is just that, fear.

👍

even if we add assertions to every rule in our codebase it wouldn't mean any external rule could use it. Which would mean auto-fixing wouldn't possible for the them.

👍

On the other hand, give users API to change your code is dangerous.

👍, but it's a fear ;-) If you using a plugin — ask plugin developer why it fails.

If you using JSCS as a plugin to IDE or Some smart editor — usually you have a choice to not save file and, moreover, cancel changes with Ctrl+Z/Cmd+Z.

Most of folks using VCS so they can look at changes and decline them if it wrong.

What you think about Assertion API. Is it ready to be public?

markelog added a commit to markelog/node-jscs that referenced this issue May 30, 2015
markelog added a commit to markelog/node-jscs that referenced this issue May 30, 2015
markelog added a commit to markelog/node-jscs that referenced this issue May 30, 2015
markelog added a commit to markelog/node-jscs that referenced this issue May 31, 2015
markelog added a commit to markelog/node-jscs that referenced this issue May 31, 2015
markelog added a commit to markelog/node-jscs that referenced this issue Jun 5, 2015
markelog added a commit to markelog/node-jscs that referenced this issue Jun 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants