This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
CLI: Incorrect ERRORLEVEL being reported to stdOut #212
Comments
markelog
added a commit
to markelog/node-jscs
that referenced
this issue
Jan 29, 2014
* Return "2" exit code for lint errors. Fixes jscs-dev#212 * Use promise to determine what exit code should we use, it would simplify testing, since most jscs operations are executed asynchronously * Move all data files for cli module to subfolder * Start using sinon * Change return value of cli module - object with checker and promise attributes
markelog
added a commit
to markelog/node-jscs
that referenced
this issue
Jan 29, 2014
* Return "2" exit code for lint errors. Fixes jscs-dev#212 * Use promise to determine what exit code should we use, it would simplify testing, since most jscs operations are executed asynchronously * Move all data files for cli module to subfolder * Start using sinon * Change return value of cli module - object with checker and promise attributes
markelog
added a commit
to markelog/node-jscs
that referenced
this issue
Jan 29, 2014
* Return "2" exit code for lint errors. Fixes jscs-dev#212 * Use promise to determine what exit code should we use, it would simplify testing, since most jscs operations are executed asynchronously * Remove exit code logic from the reporters * Move all data files for cli module to subfolder * Start using sinon * Change return value of cli module - object with checker and promise attributes
markelog
added a commit
to markelog/node-jscs
that referenced
this issue
Jan 29, 2014
* Return "2" exit code for lint errors. Fixes jscs-dev#212 * Use promise to determine what exit code should we use, it would simplify testing, since most jscs operations are executed asynchronously * Remove exit code logic from the reporters * Move all data files for cli module to subfolder * Start using sinon * Change return value of cli module - object with checker and promise attributes
|
Thanks. @markelog, when is the next release scheduled? |
|
We should be able to do it after the seventh February, maybe earlier. |
|
Thanks. Hopefully this issue will also be resolved in the next release #211 |
This was referenced Feb 4, 2014
Merged
ChrisTorng
referenced
this issue
in ChrisTorng/WebEssentials2013
Feb 9, 2014
Combine JsHint and JSCS rule and cleanup excludeFiles. Hack to stop <xml and more than 500 errors. Revert Regex.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Both TsLint and JsHint, set stdOut's ERRORLEVEL = 2 when there are linting errors reported in output.
JSCS, however, returns ERRORLEVEL 0 even when there are styling issues found.
Please fix this and make it consistent with TsLint and JsHint.
The same issue was recently resolved by node-sass. See arian/node-sass@dd7f509.
Thanks.
The text was updated successfully, but these errors were encountered: