Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Regression: excluded files are linted #488

Closed
mgol opened this issue Jun 30, 2014 · 6 comments
Closed

Regression: excluded files are linted #488

mgol opened this issue Jun 30, 2014 · 6 comments
Labels
bug

Comments

@mgol
Copy link

mgol commented Jun 30, 2014

I have this in my .jscsrc file:

"excludeFiles": [
    "node_modules/**",
    "test/*/**/*.js"
]

and yet I get an error:

Running "jscs:all" (jscs) task
Warning: Syntax error at test/bower-fixtures/not-ok-install-copy/bower_components/jquery/src/intro.js: Line 45: Unexpected end of input Use --force to continue.

JSCS 1.5.6.
mgol added a commit to mgol/check-dependencies that referenced this issue Jun 30, 2014
@mgol
Workaround JSCS error
8563b5d 
See jscs-dev/node-jscs#488
@mgol
Copy link
Author

mgol commented Jun 30, 2014

It also stopped catching "app/vendor/**" etc.

@mgol mgol changed the title Excluded files are linted Regression: excluded files are linted Jun 30, 2014
@mgol
Copy link
Author

mgol commented Jun 30, 2014

The first bad commit is d1c7267. @markelog, can you have a look?

@markelog
Copy link
Member

Yeah, should release new version today

@markelog
Copy link
Member

Matter of fact, could you try jscs with #477 changes?

@mgol
Copy link
Author

mgol commented Jun 30, 2014

Will do.

@mgol
Copy link
Author

mgol commented Jun 30, 2014

Works fine with #477!

markelog added a commit to markelog/node-jscs that referenced this issue Jun 30, 2014
@markelog
Correct deal with exclusion and extensions
041fd3f 
Fixes jscs-dev#488
@markelog markelog added the bug label Jun 30, 2014
@markelog markelog mentioned this issue Jun 30, 2014
Closed
gustavohenke pushed a commit to jscs-dev/grunt-jscs that referenced this issue Jun 30, 2014
Bump jscs to 1.5.7
16c856a 
Due to the problems reported in jscs-dev/node-jscs#488, we'll bump
directly to jscs 1.5.7, version with the proper fix for that issue.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct deal with exclusion and extensions markelog/node-jscs
2 participants
@markelog @mgol