file extension fixes. Fixes #2275 #2273

[graingert]

Fixes #2275 #2273

[coveralls]

Coverage decreased (-0.02%) to 96.713% when pulling c3f051e on graingert:prevent-defaults-overriding-config into 5885239 on jscs-dev:master.

[coveralls]

Coverage decreased (-0.02%) to 96.713% when pulling 1da372c on graingert:prevent-defaults-overriding-config into 5885239 on jscs-dev:master.

[coveralls]

Coverage increased (+0.003%) to 96.733% when pulling 72a2aec on graingert:prevent-defaults-overriding-config into 5885239 on jscs-dev:master.

[coveralls]

Coverage increased (+0.003%) to 96.733% when pulling 72a2aec on graingert:prevent-defaults-overriding-config into 5885239 on jscs-dev:master.

[markelog]

Decided to fix this a bit differently, would appreciate a second look though - 0d027a7

[graingert]

@markelog this doesn't fix #2273

[markelog]

It's not supposed to

[graingert]

Can you reopen #2273 so I can recreate the PR to fix it?
On 21 Jun 2016 9:18 pm, "Oleg Gaidarenko" notifications@github.com wrote:

It's not supposed to

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2276 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAZQTCeZNE9t6IyTqursHEg1WQnxRjMrks5qOEb0gaJpZM4I5kA1
.

[markelog]

I don't know man, everywhere i looked, like https://en.wikipedia.org/wiki/File_format#Filename_extension, https://en.wikipedia.org/wiki/Filename_extension https://docs.python.org/2/library/os.path.html#os.path.splitext,
path.extname of node.js,
http://ruby-doc.org/core-2.2.0/File.html#method-c-extname,
https://golang.org/pkg/path/filepath/#Ext
and others... give me the same result

[markelog]

You can probably workaround it with something like this though -

"excludeFiles": ["**/!(*.es2015.js)"]

[graingert]

@markelog nope, that seems to exlude all files.

[markelog]

It should ignore all files which ends with .es2015.js

[graingert]

@markelog I know. But it seems to exclude all files

[markelog]

Oh shoot, typo there, it shouldn't ignore files which ends with .es2015.js

[graingert]

Sorry I doubled the mistake and thought that's what you said originally. It still ignores all files

[markelog]

Weird, works for me

[markelog]

Maybe you could illustrate it with test repo?

[graingert]

Yeah will do
On 28 Jun 2016 9:25 pm, "Oleg Gaidarenko" notifications@github.com wrote:

Maybe you could illustrate it with test repo?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2276 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAZQTKtKVU7youjy8hV-pMdOROWO0-5-ks5qQYNMgaJpZM4I5kA1
.