-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fatal: bad revision 'v1.10.10..HEAD' #132
Comments
Hi, could you tell me what is the version in your package.json file and also what is the name of the last git tag? |
Hi, thanks for reaching out so quickly! Package.json version: 1.10.12 |
Actually, the error is now |
Same here.
|
FYI It works with v1.3.1 |
v1.3.2 was basically a fix to log this kind of error in the terminal, instead of silently failing, I'm not sure the issue comes from this release, by any chance is your repo accessible? It would help me a lot, meanwhile, I will try to reproduce this locally. |
Just tried with v1.3.1 and v1.3.0 and they both fail silently, so the issue is not with this version itself. If it's of any help, I switched from WSL back to Windows few days ago and the issue only started happening after that. I'm afraid I can't share the repo since it's for internal use only. :/ |
Interesting! it means it's possibly a compatibilty issue with windows, how will I debug this since I'm on Linux. 😄 |
Does tagging the commit as a simple tag or an annotated tag make any difference in how the library handles the following tags? |
I don't think so, both should be a valid pointer in the git history. Could you run To make it clear, the version in package.json should refer to a valid git tag, for example, if you have This behavior was recently changed (#117 and #102), but it's not yet released, now on master we just pull the last semver tag, the version in the package.json is not used as an input anymore. |
I am on Mac OS Big Sur and have the same issue |
Running the command:
Produces: My package.json is at 13.0.0. It was a version I recently added arbitrarily because of previous failures with the semver plugin. FYI I never develop in a tag that contains the version number. Is that a requirement of your plugin? I am confused. We use gitflow and work in "develop" branch. We just migrated our existing code to a new Git repo that contains no tags. FYI This error also occurs in a clean new project when using v1.3.2 of your plugin. Sorry. Also cannot share the company codebase. |
This is the reason why it's failing, semver relies on git tags, to compute the next version it tries to retrieve all commits since last git tag, if no tag found then it couldn't know from which point in the history it should compute the next version, to fix it you have to create a tag wherever it has a sense in your history, and sync it with the version in your package.json. |
Just found where the issue was: running |
Well, apparently it's not fully solved. It worked until doing a dry run, but at the moment of actually running the command I get this error: |
I can't help you more without seeing your git history. To produce the next version we depend on a module used by almost 10 million projects on GitHub, I'm quite confident it's not a bug from the library, but in case you can reproduce it, feel free to open another issue.
This one was also solved previously (#108), but not yet released. I will see today if I can release a new version. |
Awesome, thank you very much! |
Creating a Git tag with the name v13.0.0 (current version in package.json) fixed this issue for me. |
Hey there @edbzn! Any news on the update? Sorry to bother you and thanks in advance, but I was wondering when it will be available :) |
Sorry for the delay I just released a new version 1.4.0 with all the fixes, let me know if any problems persist. |
Everything works, thanks for your time @edbzn! And no worries about the delay ;) |
Running
nx run workspace:version
fails and logsError: fatal: bad revision 'v1.10.10..HEAD'
.Any idea about how to solve this?
The text was updated successfully, but these errors were encountered: