🚧 enhance get current version #117
Conversation
Codecov Report
@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 96.15% 95.96% -0.20%
==========================================
Files 16 16
Lines 312 322 +10
Branches 35 32 -3
==========================================
+ Hits 300 309 +9
- Misses 7 8 +1
Partials 5 5
Continue to review full report at Codecov.
|
| getLastTag().pipe( | ||
| tap((tag) => { | ||
| logger.warn(`🟠 No previous semver tag found, fallback from: ${tag}`); | ||
| }) | ||
| ) |
There was a problem hiding this comment.
@edbzn I think that getLastTag is a dangerous fallback heuristic. In most cases, this will produce a surprising behavior.
I am thinking about a monorepo with lots of already versioned packages (a=3.0.0, b=4.0.0)then we add a new package. This package will then use the version of the last tagged package (a or b) which is wrong.
we can just skip this step
There was a problem hiding this comment.
The other thing here is that getLastTag() returns a tag and not a version.
| switchMap((since) => | ||
| iif(() => since === `0.0.0`, getFirstCommitRef(), of(since)) | ||
| ) |
There was a problem hiding this comment.
When the current version is not found, maybe since's value should be null. This way we can make the difference between detecting a 0.0.0 version and not detecting any version.
If since is null (or currently 0.0.0), then before bumping, we can log something like: Couldn't find a previous version tag for this project. New version will be calculated based on all changes since first commit. If your project is already versioned, please tag the last release commit with my-prefix-x-y-z and run this command again.
|
Agree! Let's improve this. |
Co-authored-by: Younes Jaaidi <yjaaidi@gmail.com>
Following this discussion #102, handle the current version differently, @yjaaidi what do you think?