build: migrate to ngx-deploy-npm@8.0.0 #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianjuar
commented
Jan 19, 2024
| @@ -10,7 +10,7 @@ | |||
| "options": { | |||
| "push": true, | |||
| "noVerify": true, | |||
| "postTargets": ["publish", "github"], | |||
| "postTargets": ["build", "publish", "github"], | |||
There was a problem hiding this comment.
Since runExecutor DevKit function is used under the hood on the postTargetoption, we need to specify the dependant targets of publish
For more context, see #771
There was a problem hiding this comment.
Should we update the @jscutlery/semver code examples to reflect this new behavior of ngx-deploy-npm and raise awareness among the users that adopt both plugins?
There was a problem hiding this comment.
@dianjuar I just merged your branch and updated the docs! Thanks for the work.
3 tasks
dianjuar
force-pushed
the
ngx-deploy-npm-update-v8
branch
from
158e755
to
741a3ed
Compare
edbzn
force-pushed
the
ngx-deploy-npm-update-v8
branch
from
741a3ed
to
3599317
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngx-deploy-npm v8 introduced some breaking changes. This PR applies the migration scripts and other necessary changes to adapt version 8 properly.
More information about V8 changes can be found in the blog post What's coming to ngx-deploy-npm V8