Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create role permissions #68

Merged
merged 6 commits into from
Jun 23, 2018
Merged

Create role permissions #68

merged 6 commits into from
Jun 23, 2018

Conversation

jsdecena
Copy link
Owner

Implement Role / Permissions

Restrict access to certain pages and allows the admin to set permission to roles

Conflicts:
	app/Shop/Roles/Repositories/RoleRepositoryInterface.php
	routes/web.php
Conflicts:
	app/Providers/GlobalTemplateServiceProvider.php
	app/Shop/Employees/Repositories/EmployeeRepository.php
	config/auth.php
Conflicts:
	resources/views/layouts/admin/sidebar.blade.php
Conflicts:
	app/Http/Controllers/Front/ProductController.php
	app/Providers/RepositoryServiceProvider.php
	resources/views/admin/shared/products.blade.php
	resources/views/layouts/admin/sidebar.blade.php
@jsdecena jsdecena self-assigned this Jun 23, 2018
@jsdecena jsdecena mentioned this pull request Jun 23, 2018
@codecov
Copy link

codecov bot commented Jun 23, 2018

Codecov Report

Merging #68 into develop will decrease coverage by 1.01%.
The diff coverage is 78.35%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #68      +/-   ##
=============================================
- Coverage      90.95%   89.94%   -1.02%     
- Complexity       521      554      +33     
=============================================
  Files            119      125       +6     
  Lines           1746     1839      +93     
=============================================
+ Hits            1588     1654      +66     
- Misses           158      185      +27
Impacted Files Coverage Δ Complexity Δ
app/Http/Middleware/RedirectIfNotCustomer.php 0% <0%> (ø) 2 <2> (?)
...rollers/Admin/Permissions/PermissionController.php 100% <100%> (ø) 2 <2> (?)
...p/Controllers/Admin/Products/ProductController.php 94.61% <100%> (+0.17%) 31 <0> (ø) ⬇️
app/Shop/Roles/Requests/CreateRoleRequest.php 100% <100%> (ø) 1 <1> (?)
app/Shop/Roles/Requests/UpdateRoleRequest.php 100% <100%> (ø) 1 <1> (?)
app/Providers/RepositoryServiceProvider.php 100% <100%> (ø) 1 <0> (ø) ⬇️
...Shop/Employees/Repositories/EmployeeRepository.php 92% <100%> (-8%) 11 <0> (ø)
app/Http/Middleware/RedirectIfNotEmployee.php 100% <100%> (ø) 2 <2> (?)
app/Http/Controllers/Admin/LoginController.php 100% <100%> (ø) 5 <0> (ø) ⬇️
app/Shop/Roles/Repositories/RoleRepository.php 67.74% <50%> (-32.26%) 14 <10> (+10)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27cc761...91c11b6. Read the comment docs.

@jsdecena jsdecena merged commit 47e5372 into develop Jun 23, 2018
@jsdecena jsdecena deleted the create-role-permissions branch June 26, 2018 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant