Skip to content
This repository has been archived by the owner on Feb 11, 2021. It is now read-only.

Possible incorrect flagging of minimized JS file #11

Closed
bradberger opened this issue May 21, 2014 · 4 comments
Closed

Possible incorrect flagging of minimized JS file #11

bradberger opened this issue May 21, 2014 · 4 comments

Comments

@bradberger
Copy link

Not sure if this is an issue/bug or not, but the bot flagged a file in this PR for angular-dragdrop.min.js as not minimized, but it definitely is.

There are perhaps excessive comments in the top of the file (seems like licensing mainly) but the JS code itself is definitely minimized.

@tomByrer
Copy link

There are perhaps excessive comments in the top of the file (seems like licensing mainly)

Yea, I wish devs would not take this literally:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

I'm not a legal expert, but I'd think @license MIT works just fine without the 3 paragraphs. Plus, one of the other minified files do not include anything, & others don't have a (c)/@license.

I encourage repo owners & uploaders to ensure there is a brief file ID, version, (c)/@license for every file uploaded, since jsDelivr can collate files (& other utils can also). I have my own top-comments ideas, but really any format works. Plus jsDelivr doesn't enforce anything, just warns :)

@tomByrer
Copy link

Did note to knock out comments prior to testing, so thanks for bringing this up @bradberger

@bradberger
Copy link
Author

Cool. I agree that that much inline licensing is perhaps excessive. It seems likely that most people - myself included - don't know and ignore the differences between licenses. One line seems more than enough.

Anyhow, thanks for taking a look at it.

@tomByrer
Copy link

Thanks for reporting your error report; helps us engineer improvements.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants