Skip to content
This repository has been archived by the owner on Feb 11, 2021. It is now read-only.

Add an option to request re-check #65

Closed
zlatanvasovic opened this issue Sep 22, 2016 · 4 comments
Closed

Add an option to request re-check #65

zlatanvasovic opened this issue Sep 22, 2016 · 4 comments

Comments

@zlatanvasovic
Copy link

You basically have to submit a new PR if it fails in eyes of the bot, right? Why not add an option to recheck on request, such as "[at sign]jsdelivrbot please re-check", or "please revalidate", something like that. It'd be very helpful to reduce the PR spam.

@megawac
Copy link
Contributor

megawac commented Dec 11, 2016

@zdroid we revalidate on every new commit. The thing is the bot only posts a message on the pull request once. If you click on a x on a pull request commit or on details at the bottom of the pull request you'll see the full message (https://gist.github.com/jsdelivrbot/d6659f7c360330dceb0ae1cb9a631130). The reason we do this is to avoid spamming a pull request with comments

@megawac megawac closed this as completed Dec 11, 2016
@zlatanvasovic
Copy link
Author

Thanks for clarifying. 😄

@megawac
Copy link
Contributor

megawac commented Dec 11, 2016

Sorry for late response though. I wish github allowed you to configure emails to be sent based on the repo. For example, I would not want an email every time a PR is created on jsdelivr but I would on this repo

@zlatanvasovic
Copy link
Author

@megawac You can try making teams or something. Or just use watch plain and simple — it doesn't have specific settings but it works fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants