Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DB setup in tests #451

Closed
MartinKolarik opened this issue Dec 4, 2023 · 0 comments · Fixed by #458
Closed

Fix DB setup in tests #451

MartinKolarik opened this issue Dec 4, 2023 · 0 comments · Fixed by #458
Assignees

Comments

@MartinKolarik
Copy link
Member

MartinKolarik commented Dec 4, 2023

The tests must set up the expected DB state before running, not only in the CI as now, but also locally (from the node process). See https://github.com/jsdelivr/data.jsdelivr.com/blob/master/test/setup-db.js for a good example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants