Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static attribute setters #211

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Fix static attribute setters #211

merged 1 commit into from
Apr 29, 2020

Conversation

ExE-Boss
Copy link
Contributor

Fixes #199

@TimothyGu
Copy link
Member

This looks good, but I'm wondering if we can fix #186 at the same time. I'm not entirely sure what the shape of the API should look like though… maybe Impl.implementation.set${camelCase(attr)}(globalObject, value)?

@domenic
Copy link
Member

domenic commented Apr 28, 2020

Chromium does it via [CallWith=] nonstandard extended attributes, so that the impl class opts in to the unusual parameters.

@domenic
Copy link
Member

domenic commented Apr 29, 2020

Anyway, my vote would be for merging this without blocking on the additional scope of #186. WDYT, @TimothyGu?

@TimothyGu
Copy link
Member

I was hoping to get something decided before a major version bump, but that ship has sailed so this is fine for me.

@domenic domenic merged commit 7d45dfc into jsdom:master Apr 29, 2020
@domenic domenic mentioned this pull request Apr 29, 2020
Closed
@ExE-Boss ExE-Boss deleted the fix/interface/static-attribute-setter branch April 30, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static setter code is broken
3 participants
@ExE-Boss @TimothyGu @domenic