Attempt to use the builtin and switch to Uint8Array #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got stuck on nodejs/node#40091 making it hard to write tests for the error case, so I'm abandoning this for now, but uploading it as reference.
From some brief testing it doesn't look like we got that particular error case right in the past, either, although in a different way.
This would solve #7. Although we'd probably want to explain the unusual architecture of the package in the readme a bit more.
This also adds support for the
fatal
mode from the spec; previously I believe we were implicitly usingreplacement
. Probably this is useful for work like #11.