Parse all aggregations #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Investments transactions can have many types; parse them all. - Change type attribute on InvestmentTransaction to a string
Tests <TRANSACTION> aggregate type, among other things.
|
Related: #74 but this a little more comprehensive, and also includes a behavior change. Thank you! |
|
If you'd prefer, I can switch back to the enum-style type. I notice you are using that pattern elsewhere. |
|
I'm fine with the pattern you used. Thank you for the fixes (and tests)! |
|
I also added you to AUTHORS |
|
Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was missing transactions when using ledger-autosync. It turns out they were
<TRANSFER>aggregations. This modifies ofxparse to parse all aggregation types (as defined in 2.1.1 of the spec (http://www.ofx.net/DownloadPage/Downloads.aspx)). It also changes thetypeattribute of theInvestmentTransactionto be a string instead of the less useful number.Thanks!