Optional random ports for Embedded Cassandra #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…often fails because embedded cassandra uses fixed ports and thus cannot be started in parallel. This patch allows to set a "0"-port in the configuration, which is automatically replaced by any (random) free port. The chosen port can be read by EmbeddedCassandraServerHelper#getNativeTransportPort. For convenience a predefined configuration is also provided as an option.
…ssandraServerHelper (if not explicitly configured)
…ssandraServerHelper (if not explicitly configured)
get rid of the now useless hostport-constructors
…t of the configfile
…assandra can be started before springcontext
|
Hi Markus, thanks for this contribution as well. a real good proposal. I will have a deeper look asap |
jsevellec
added a commit
that referenced
this pull request
May 8, 2015
Optional random ports for Embedded Cassandra
|
I've just published a 2.1.3.2-SNAPSHOT containing the PR |
|
This is exactly what we are looking for, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Jenkins may start multiple jobs containing an embedded cassandra in parallel. This leads to build errors due to duplicate ports.
This pull request reads the yaml before starting cassandra and replaces ports with value 0 by a random free port. Getters for port, host, cluster have been added to EmbeddedCassandraServerHelper, while configuration for these now unneeded values has been removed from the EmbeddedCassandra-Annotation.
The default yaml still contains the well known ports, so existing projects should continue to work. To use the random ports a new optional yaml has been added, which must be explicitly configured.