Issue #1451: Fix 1388 regression #1452
Conversation
| case isTypoTypeof(left, right): | ||
| warning("W122", this, left.value); | ||
| break; | ||
| case !eqnull && state.option.eqeqeq: |
There was a problem hiding this comment.
Does this change indentation only? Why?
There was a problem hiding this comment.
yep, it changes indentation only, because otherwise "npm test" does not pass here :( (this is the first commit in the PR)
There was a problem hiding this comment.
You should update JSHint. Starting with 2.3 (I think) we determine the indentation style of the switch statement and go with that. So this shouldn't fail npm test (it doesn't on my computer and on Travis).
There was a problem hiding this comment.
mmm I somehow thought that npm test was either using the current jshint source or the jshint that is in node_modules ;) My system's jshint is probably old.
There was a problem hiding this comment.
It should use node_modules JSHint afaik.
|
Your description says (not ready to merge) but the patch (indentation change aside) looks fine. Is there something else you'd like to do? |
Right, I added this before I had a proper fix. Removed the description, and you can merge if it looks fine to you ! :) |
Okay, cool. Will land today. |
|
Landed both on master and 2.x, thank you! |
No description provided.