Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[[FIX]] parse trailing comma in ObjectBindingPattern #2221

Merged
merged 1 commit into from
Feb 28, 2015
Merged

[[FIX]] parse trailing comma in ObjectBindingPattern #2221

merged 1 commit into from
Feb 28, 2015

Conversation

caitp
Copy link
Member

@caitp caitp commented Feb 28, 2015

Closes #2220

@caitp
Copy link
Member Author

caitp commented Feb 28, 2015

also fixes some potential false positives

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 96.31% when pulling 7a2b713 on caitp:issue-2220 into d82cf19 on jshint:master.

@rwaldron
Copy link
Member

For anyone interested, compare:

rwaldron added a commit that referenced this pull request Feb 28, 2015
@rwaldron
Merge pull request #2221 from caitp/issue-2220
b956fe4 
[[FIX]] parse trailing comma in ObjectBindingPattern
@rwaldron rwaldron merged commit b956fe4 into jshint:master Feb 28, 2015
jugglinmike pushed a commit to jugglinmike/jshint that referenced this pull request Feb 28, 2015
@rwaldron @jugglinmike
Merge pull request jshint#2221 from caitp/issue-2220
ce10725 
[[FIX]] parse trailing comma in ObjectBindingPattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwaldron rwaldron

Labels
ES6 P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trailing comma is allowed in ObjectBindingPattern
3 participants
@caitp @coveralls @rwaldron