Es8 trailing comma #3303
Merged
Es8 trailing comma #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaldron
reviewed
Jul 10, 2018
| test/language/statements/class/meth-static-params-trailing-comma-multiple.js(default) | ||
| test/language/statements/class/meth-static-params-trailing-comma-multiple.js(strict mode) | ||
| test/language/statements/class/meth-static-params-trailing-comma-single.js(default) | ||
| test/language/statements/class/meth-static-params-trailing-comma-single.js(strict mode) |
|
@jugglinmike please review and resolve conflicts. Ping me when ready for follow up |
This change simply enables the configuration settings `esversion: 8` and `esversion: 2017` without introducing any new parsing/linting functionality.
jugglinmike
force-pushed
the
es8-trailing-comma
branch
from
df048fb
to
e62692c
Compare
|
Sure thing. Original version of this branch is available here: |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to resolve gh-3265