-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to fix failing, stale build #27
Conversation
leonowski
commented
Aug 29, 2020
- update to ubuntu Focal (required for latest wine package install)
- update to latest versions of novnc and websockify
- add python as Focal needs it specified.
- add cifs-utils so users can mount shares in container and thus write to network shares in BlueIris
- add unzip so we can run it in blueiris.sh and extract ui3.zip (fixes issues where ui3 doesn't work)
…with higher resolution and logging changes
Few things I forgot to mention in the readme and it should probably go in somewhere:
1 - Destroying the container (save persistent data location). That should force a redownload of the latest version and the install wizard should be upgrade focused. This should also trigger the uninstall/repair dialog if it's the same exact version. |
I pulled down this branch and am building and testing. I had some weird results using my previous volume mounted data ( |
@TonyBrobston I just built it and ran it and had the same issue. |
@leonowski Is the same happening for you? |
Strange. I do not have that issue now. It goes through the install and finishes properly. After you launch a fresh container with a fresh volume mounted for /root/prefix32, tail the docker log (or run it interactively). Watch for the blueiris.exe download. Wait for that to finish and then visit the GUI. I do remember running into that problem early in my trials - but I don't remember what was done to fix it. Just make sure your prefix dir is clean (basically, start from scratch). On a side note: I also made this install the 64-bit binary install instead of the 32-bit version. I put it up on my repo in the dev branch. It's simply a matter of turning off the ENV VAR for the WINEARCH and removing all the "32" references. I'll put up a PR for that later. |
That may be why the visual c++ installer didn't give you problems. That PR would be great. Since docker only runs on x64 machines anyways, I see no downside to this dependency. |
OK, but the 32-bit version did work for me. I suspect the same problem will still happen. You should start with a clean prefix environment for wine. |
I've been running with no volume mount, so I believe it would be a clean environment every time. Maybe I'm not understanding something and it's somehow running off an old container or old built image. I have been running |
I just finished that build and ran into the same "Setup Failed" as above. I've been trying to google on "0x80070643" and wine, but I haven't come up with much. I'll keep digging. |
If your containers are stopped and you aren't mounting any external volumes, it should persist your data since it is in the container filesystem layer. The only way to destroy the data is to It's best to mount an external volume for the /root/prefix path in the container (formerly /root/prefix32). That way, you can manipulate files inside the wine environment easily. You can also start fresh if you need to. The problem with this (now that I remember) could be that the wine prefix might be required to be mounted as a volume. I suggest building and running the container manually with docker directly instead of docker-compose like this:
|
I'll give that a shot. |
@leonowski I did as you suggested and got the same result. I paid more attention to the logs though (in
|
What if you try the docker image I have built? leonowski/docker-blueiris Any difference? |
I tried |
After opening a bash terminal inside vnc, I messed with installing a bunch of Microsoft Visual C++ (by saying |
After a little more testing I was able to run an install command of the current Microsoft Visual C++ version that was installed. It gave me an uninstall option. I uninstalled, then after an attempt or two to install Microsoft Visual C++ 2015 it took and then Blue Iris opened just fine. |
I just tried it on another docker host I have and noticed the same problem. It seems like I forgot to include an option I'm using to run my container: privileged mode. So, add the option Alternatively, included in the container is winetricks. You can use that to install the MS VC++ runtime using the command:
But, that shouldn't be necessary now. Try it with privileged mode. |
@leonowski Cool |
It looks like this PR is ready for merge. Any additional outstanding issues you see that need to be addressed? |
@jshridha It looks good to me. I'd like to figure out how not to need the privileged flag, but that can be explored in a future PR. I think we should keep this moving along. Great work @leonowski! |
@TonyBrobston I agree. I updated the docs to show that you only need the privileged flag for the initial run to do the Visual C++ install. After that, you're good to turn it off. |
@jshridha @leonowski Are you guys ready to merge/deploy this? |
Seems like a good solution, thanks @leonowski (and @jshridha )! |
You guys are my hero! Can't wait to get rid of my old box that's just for blueiris. |
Looks good to me. I'll merge and let dockerhub build the dev image. |