Fix for maxAge == 0 that doesn't appear in serialized data.

[tucan]

Hello!

I found and fixed one bug. Then I pass to serialize options like { maxAge: 0 } (in order to force browser to remove cookie) in output I does'n see Max-Age options. In other cases (positive or negative max ages) all are OK.

[defunctzombie]

This would fail if maxage was an empty string ''.

Should probably use a check for a number. We could employ this trick:

if (!isNaN(maxAge - 0)) { }

And ignore the value (or throw, or use 0) if it isn't a number. In this case empty string will become 0.

[tucan]

I think decision to throw an exception will be the best in this case. It's standard way for serializing functions like JSON.stringify.

If you agree this approach, I will make another pull request.

[defunctzombie]

Sure. We can throw if not a number.
On Feb 19, 2014 4:05 AM, "Vladimir Andreev" notifications@github.com
wrote:

I think decision to throw an exception will be the best in this case. It's
standard way for serializing functions like JSON.stringify.

If you agree this approach, I will make another pull request.

Reply to this email directly or view it on GitHubhttps://github.com//pull/20#issuecomment-35478494
.

[tucan]

I did it.

Approach is following:

1. Check whether opt.maxAge isn't null or undefined
2. If so try to convert it to Number
3. If failed throw Error
4. push value into pairs array