-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Expect return true immediately if If-None-Match matches the ETag header (#35) #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this work @bigbigDreamer!
AFAIK, seems like this is a major change in terms of semver. I will love to have some additional reviews before we merge it (I am not an expert on fresh
) 👍
This comment was marked as resolved.
This comment was marked as resolved.
there is no perfect answer, but you could argue that a breaking change caused by spec-compliance where you don't do a major version bump does not violate semver. unrelated but similar issue I ran into last week: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also don't have perms to approve but a ➕1 from me 😄
I am adding this to the list of required releases before we land |
Updated the PR to early return from the for loop. The change to the flow of the code allows us to do that, while previously we fell through to give the other header a chance to invalidate. When we have an if-none-match, we must decide fresh based on that |
Main Changes
Expect return true immediately if If-None-Match matches the ETag header.
Context
Closes #35