Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "audio/x-vorbis" and "audio/x-vorbis+ogg" mime types #53

Closed
wants to merge 1 commit into from

Conversation

Alcotana
Copy link

@Alcotana Alcotana commented Oct 14, 2016

This pull request is for the following issue:
Add 'audio/x-vorbis' mime types #52

@dougwilson
Copy link
Contributor

Hi @Alcotana, typically we only add types that comes from our sources (see the README). We normally do not want to add new MIME types to the custom types unless there is a very, very good reason. Can you elaborate on the following points:

  1. Why should this type be added?
  2. Why can this type not be registered with the IANA?
  3. Why can the type not be added to the nginx or Apache projects?

The mime-db project is simply meant to be an aggregation of the projects listed in the README, and not a source of any types. Adding the types to the custom types is a last resort and we'll need to understand why that needs to happen.

@dougwilson dougwilson self-assigned this Oct 15, 2016
@dougwilson dougwilson added the pr label Oct 15, 2016
@dougwilson
Copy link
Contributor

I looked into this, and the non-x- variants are already registered with the IANA. Why should the x- variants be added here? Ideally if there is a reason, the mapping should be added to either the Apache project or nginx project, I would think.

@dougwilson
Copy link
Contributor

Hi @Alcotana I'm going to close this PR since I never heard back on any of the questions in two months.

@dougwilson dougwilson closed this Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants