-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add application/wasm #97
Conversation
Eventually, 'application/wasm' should be officially registered. In the meantime, it would be very nice to have this working on Pages since [certain WebAssembly JS APIs](https://github.com/WebAssembly/design/blob/master/Web.md#additional-web-embedding-api) require the application/wasm MIME type to work at all.
src/custom-types.json
Outdated
"extensions": ["wasm"], | ||
"notes": "WebAssembly module", | ||
"sources": [ | ||
"https://webassembly.github.io/spec" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, definitely can get it added. Can you add a link to a page that at least mentions the file extension .wasm
and the MIME type application/wasm
? The page here is long, but skimming through it I didn't see either mentioned.
Add a second source link that explicitly mentions 'application/wasm'.
You bet! PTAL |
Thanks! I just took a look, but I see no mention of the file extension |
P.S. I see reading on there it talks about reading the |
Oh sorry! We mention the canonical file extension in the core spec here: But we don't mention the canonical MIME type in the same core spec. I'll file an issue because probably this is a good thing to say right next to the recommended extension. While wasm is a binary format, it is explicitly designed to leave compression to a higher level so compression is a large win. For example, in the canonical demo, the 12mb .wasm file gzips down to 3.8mb. |
This is probably a better link both for the file extension and (soon) the canonical MIME type.
(Updated PR to link directly to https://webassembly.github.io/spec/binary/conventions.html which avoids searching through the whole spec and also should soon mention 'application/wasm' MIME type.) |
Ok, https://webassembly.github.io/spec/binary/conventions.html now mentions both .wasm and application/html in the same paragraph. Anything else needed to merge this PR? |
Merged 👍 |
Thanks! Do you happen to know how often this repo is uplifted into GitHub Pages? |
Hi @lukewagner I'm not 100% sure. I know GitHub Pages uses this project to get the types, but I'm not familiar with how that gets updated, and if it is just time based or is dependent on something happening here. |
Eventually, 'application/wasm' should be officially registered. In the meantime, it would be very nice to have this working on Pages since certain WebAssembly JS APIs require the application/wasm MIME type to work at all.