-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and upgrade ci pipeline #26
Fix and upgrade ci pipeline #26
Conversation
@UlisesGascon @wesleytodd I am struggling to get the CI pipeline run on Node.js 0.6 Have you experienced this error before? Snapshot came from this run https://github.com/carpasse/range-parser/actions/runs/8936686852/job/24547511633 |
8f0e5c5
to
f4f9705
Compare
I have not seen it but to me this just looks like a great opportunity to ignore it because spending any time on supporting tests in 0.6 is a waste of effort 🤣. I personally am comfortable dropping this test target but saying: we are pretty sure it is not broken, just CI is broken. We will be dropping support and STRONGLY suggest folks not run unsupported node versions" |
Agree, I will amend the PR |
Test are most likely not broken but running the tests on such and old version is no longer feasible.
f4f9705
to
979efa7
Compare
No description provided.