Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and upgrade ci pipeline #26

Merged
merged 5 commits into from
May 7, 2024

Conversation

carpasse
Copy link
Contributor

@carpasse carpasse commented May 1, 2024

No description provided.

@carpasse
Copy link
Contributor Author

carpasse commented May 3, 2024

@UlisesGascon @wesleytodd I am struggling to get the CI pipeline run on Node.js 0.6
Screenshot 2024-05-03 at 11 11 46

Have you experienced this error before?

Snapshot came from this run https://github.com/carpasse/range-parser/actions/runs/8936686852/job/24547511633

@carpasse carpasse force-pushed the fix-and-upgrad-ci-pipeline branch 2 times, most recently from 8f0e5c5 to f4f9705 Compare May 3, 2024 09:55
@wesleytodd
Copy link
Member

I have not seen it but to me this just looks like a great opportunity to ignore it because spending any time on supporting tests in 0.6 is a waste of effort 🤣. I personally am comfortable dropping this test target but saying: we are pretty sure it is not broken, just CI is broken. We will be dropping support and STRONGLY suggest folks not run unsupported node versions"

@carpasse
Copy link
Contributor Author

carpasse commented May 4, 2024

Agree, I will amend the PR

Test are most likely not broken but running the tests on such and old version is no longer feasible.
@carpasse carpasse force-pushed the fix-and-upgrad-ci-pipeline branch from f4f9705 to 979efa7 Compare May 4, 2024 05:48
@UlisesGascon UlisesGascon merged commit 50250ef into jshttp:master May 7, 2024
28 checks passed
@carpasse carpasse deleted the fix-and-upgrad-ci-pipeline branch May 8, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants