Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respeaker_ros for Python 2.x and 3.x #284

Merged
merged 14 commits into from
Sep 15, 2021
Merged

respeaker_ros for Python 2.x and 3.x #284

merged 14 commits into from
Sep 15, 2021

Conversation

708yamaguchi
Copy link
Member

Based on #283, I add Python 2.x compatibility.
@dgorissen

dgorissen and others added 14 commits September 12, 2021 14:39
@dgorissen
Fix deprecation warning replace tostring with tobytes
2ce8a4e
@dgorissen
Use byte strings instead of unicode strings
e0fd513
@dgorissen
DOA needs to be an int for publishing
b7e9b43
@dgorissen
Search string must be a byte string
751a038
@dgorissen
Ensure chunk_per_channel is an int (py3 division change)
7863b13
@dgorissen
Remove deprecation warning fromstring -> frombuffer
c7c91d2
@dgorissen
Set cancellation option false by default to work out of the box
03175f1
@dgorissen
Change default language to english
7114a5d
@dgorissen
Listen to speech_audio topic
d526ca3
@708yamaguchi
Keep Python 2.x compatibility
da647e5
@708yamaguchi
Revert "Set cancellation option false by default to work out of the box"
f254dc9 
This reverts commit 03175f1.
@708yamaguchi
Revert "Change default language to english"
bc6967b 
This reverts commit 7114a5d.
@708yamaguchi
Revert "Listen to speech_audio topic"
4deacf0 
This reverts commit d526ca3.
@708yamaguchi
Add self_cancellation variable to sample_respeaker.launch
b7514a2
@708yamaguchi 708yamaguchi mentioned this pull request Sep 13, 2021
Closed
@k-okada k-okada merged commit 7fc1c0b into jsk-ros-pkg:master Sep 15, 2021
@708yamaguchi 708yamaguchi deleted the dgorissen branch November 24, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knorth55 knorth55 knorth55 approved these changes

Assignees
No one assigned
Labels
respeaker_ros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@708yamaguchi @knorth55 @k-okada @dgorissen